netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florent Fourcot <florent.fourcot@wifirst.fr>
Cc: Romain Bellan <romain.bellan@wifirst.fr>,
	netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next v5 1/1] netfilter: ctnetlink: add kernel side filtering for dump
Date: Fri, 29 May 2020 20:04:25 +0200	[thread overview]
Message-ID: <20200529180425.GA30992@salvia> (raw)
In-Reply-To: <66100a4b-a879-a8f4-f684-2b098a89cdc8@wifirst.fr>

Hi,

Just a followed up after including your ctnetlink update in the last
upstream pull request for net-next.

I think you already mentioned, but it should be possible to extend
the conntrack utility to support for kernel side filtering seamlessly.

The idea is to keep the userspace filtering as a fallback, regardless
the kernel supports for CTA_FILTER or not.

I'm missing one feature in the CTA_FILTER, that is the netmask
filtering for IP addresses. It would be also good to make this fit
into libnetfilter_conntrack.

Probably this patch can be extended to include two objects, the
conntrack object that represents the exact matching (values) and
another one that represent the mask:

https://patchwork.ozlabs.org/project/netfilter-devel/patch/20200129094719.670-1-romain.bellan@wifirst.fr/

The mask object would only work for the IP address and mark.

Probably rename NFCT_FILTER_DUMP_TUPLE to NFCT_FILTER_DUMP, which
would provide the most generic version to request kernel side
filtering.

Thanks.

  parent reply	other threads:[~2020-05-29 18:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-30 20:46 [PATCH nf-next v5 1/1] netfilter: ctnetlink: add kernel side filtering for dump Romain Bellan
2020-04-26 21:43 ` Pablo Neira Ayuso
2020-05-04 19:37   ` Florent Fourcot
2020-05-05 19:14     ` Pablo Neira Ayuso
2020-05-29 18:04     ` Pablo Neira Ayuso [this message]
2020-06-04 16:08       ` Florent Fourcot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200529180425.GA30992@salvia \
    --to=pablo@netfilter.org \
    --cc=florent.fourcot@wifirst.fr \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=romain.bellan@wifirst.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).