From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: Mike Dillinger <miked@softtalker.com>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] tests: 0044interval_overlap_0: Repeat insertion tests with timeout
Date: Tue, 16 Jun 2020 00:05:43 +0200 [thread overview]
Message-ID: <20200615220543.GA26718@salvia> (raw)
In-Reply-To: <99aaa1c20475b24ce52d767d1104a7ad64c00350.1591141568.git.sbrivio@redhat.com>
On Wed, Jun 03, 2020 at 01:51:20AM +0200, Stefano Brivio wrote:
> Mike Dillinger reported issues with insertion of entries into sets
> supporting intervals that were denied because of false conflicts with
> elements that were already expired. Partial failures would occur to,
> leading to the generation of new intervals the user didn't specify,
> as only the opening or the closing elements wouldn't be inserted.
>
> The reproducer provided by Mike looks like this:
>
> #!/bin/bash
> nft list set ip filter blacklist4-ip-1m
> for ((i=1;i<=10;i++)); do
> nft add element filter blacklist4-ip-1m {$i.$i.$i.$i}
> sleep 1
> done
> nft list set ip filter blacklist4-ip-1m
>
> which, run in a loop at different intervals, show the different kind
> of failures.
>
> Extend the existing test case for overlapping and non-overlapping
> intervals to systematically cover sets with a configured timeout.
Also applied, thanks.
prev parent reply other threads:[~2020-06-15 22:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 23:51 [PATCH nft] tests: 0044interval_overlap_0: Repeat insertion tests with timeout Stefano Brivio
2020-06-15 22:05 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200615220543.GA26718@salvia \
--to=pablo@netfilter.org \
--cc=miked@softtalker.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).