Re: [PATCH nf-next] nft_set_pipapo: Drop useless assignment of scratch map index on insert

[Stefano Brivio <sbrivio@redhat.com>]

On Wed, 17 Jun 2020 22:07:05 +0200
Pablo Neira Ayuso <pablo@netfilter.org> wrote:

> On Sun, Jun 14, 2020 at 11:42:07PM +0200, Stefano Brivio wrote:
> > In nft_pipapo_insert(), we need to reallocate scratch maps that will
> > be used for matching by lookup functions, if they have never been
> > allocated or if the bucket size changes as a result of the insertion.
> > 
> > As pipapo_realloc_scratch() provides a pair of fresh, zeroed out
> > maps, there's no need to select a particular one after reallocation.
> > 
> > Other than being useless, the existing assignment was also troubled
> > by the fact that the index was set only on the CPU performing the
> > actual insertion, as spotted by Florian.
> > 
> > Simply drop the assignment.
> > 
> > Reported-by: Florian Westphal <fw@strlen.de>
> > Fixes: 3c4287f62044 ("nf_tables: Add set type for arbitrary concatenation of ranges")  
> 
> Hm.
> 
> It has a Fixes: tag.
> 
> Probably route this through nf.git instead?

I wouldn't, because it just removes a redundant assignment (so I
consider it a fix) but it doesn't fix any functional issue. Is there a
specific reason why I should?

-- 
Stefano