From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Jose M. Guisado Gomez" <guigom@riseup.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nftables] parser_bison: fail when specifying multiple comments
Date: Tue, 22 Sep 2020 01:17:58 +0200 [thread overview]
Message-ID: <20200921231758.GA6138@salvia> (raw)
In-Reply-To: <20200910164019.86192-1-guigom@riseup.net>
On Thu, Sep 10, 2020 at 06:40:20PM +0200, Jose M. Guisado Gomez wrote:
> Before this patch grammar supported specifying multiple comments, and
> only the last value would be assigned.
>
> This patch adds a function to test if an attribute is already assigned
> and, if so, calls erec_queue with this attribute location.
>
> Use this function in order to check for duplication (or more) of comments
> for actions that support it.
>
> > nft add table inet filter { flags "dormant"\; comment "test"\; comment "another"\;}
>
> Error: You can only specify this once. This statement is duplicated.
> add table inet filter { flags dormant; comment test; comment another;}
> ^^^^^^^^^^^^^^^^
Applied, thanks.
prev parent reply other threads:[~2020-09-21 23:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 16:40 [PATCH nftables] parser_bison: fail when specifying multiple comments Jose M. Guisado Gomez
2020-09-21 23:17 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200921231758.GA6138@salvia \
--to=pablo@netfilter.org \
--cc=guigom@riseup.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).