From: Florian Westphal <fw@strlen.de>
To: Phil Sutter <phil@nwl.cc>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>, netfilter-devel@vger.kernel.org
Subject: Re: [net-next PATCH 0/2] netfilter: Improve inverted IP prefix matches
Date: Fri, 2 Oct 2020 00:25:36 +0200 [thread overview]
Message-ID: <20201001222536.GB12773@breakpoint.cc> (raw)
In-Reply-To: <20201001165744.25466-1-phil@nwl.cc>
Phil Sutter <phil@nwl.cc> wrote:
> The following two patches improve packet throughput in a test setup
> sending UDP packets (using iperf3) between two netns. The ruleset used
> on receiver side is like this:
>
> | *filter
> | :test - [0:0]
> | -A INPUT -j test
> | -A INPUT -j ACCEPT
> | -A test ! -s 10.0.0.0/10 -j DROP # this line repeats 10000 times
> | COMMIT
>
> These are the generated VM instructions for each rule:
>
> | [ payload load 4b @ network header + 12 => reg 1 ]
> | [ bitwise reg 1 = (reg=1 & 0x0000c0ff ) ^ 0x00000000 ]
Not related to this patch, but we should avoid the bitop if the
netmask is divisble by 8 (can adjust the cmp -- adjusting the
payload expr is probably not worth it).
> | [ cmp eq reg 1 0x0000000a ]
> | [ counter pkts 0 bytes 0 ]
Out of curiosity, does omitting 'counter' help?
nft counter is rather expensive due to bh disable,
iptables does it once at the evaluation loop only.
next prev parent reply other threads:[~2020-10-01 22:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 16:57 [net-next PATCH 0/2] netfilter: Improve inverted IP prefix matches Phil Sutter
2020-10-01 16:57 ` [net-next PATCH 1/2] net: netfilter: Enable fast nft_cmp for inverted matches Phil Sutter
2020-10-02 13:50 ` [net-next PATCH 1/2 v2] " Phil Sutter
2020-10-04 19:10 ` Pablo Neira Ayuso
2020-10-01 16:57 ` [net-next PATCH 2/2] net: netfilter: Implement fast bitwise expression Phil Sutter
2020-10-04 19:11 ` Pablo Neira Ayuso
2020-10-01 22:25 ` Florian Westphal [this message]
2020-10-02 9:00 ` [net-next PATCH 0/2] netfilter: Improve inverted IP prefix matches Phil Sutter
2020-10-21 10:43 ` Pablo Neira Ayuso
2020-10-21 10:49 ` Pablo Neira Ayuso
2020-10-26 12:29 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001222536.GB12773@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).