From: Florian Westphal <fw@strlen.de>
To: <netfilter-devel@vger.kernel.org>
Cc: alexanderduyck@fb.com, edumazet@google.com,
Florian Westphal <fw@strlen.de>
Subject: [PATCH nf 0/4] netfilter: conntrack: remove 64kb max size assumptions
Date: Tue, 9 Aug 2022 15:16:31 +0200 [thread overview]
Message-ID: <20220809131635.3376-1-fw@strlen.de> (raw)
Some of our dated conntrack helpers assume skbs can't contain
tcp packets larger than 64kb.
Update those. For SANE, I don't see a reason for the
'full-packet-copy', just extract the sane header.
For h323, packet gets capped at 64k; larger one will be
seen as truncated.
For irc, cap at 4k: a line length should not exceed 512 bytes.
For ftp, use skb_linearize(), its the most simple way to resolve this.
Florian Westphal (4):
netfilter: conntrack: sane: remove pseudo skb linearization
netfilter: conntrack: h323: cap packet size at 64k
netfilter: conntrack_ftp: prefer skb_linearize
netfilter: conntrack_irc: cap packet search space to 4k
net/netfilter/nf_conntrack_ftp.c | 24 +++------
net/netfilter/nf_conntrack_h323_main.c | 10 +++-
net/netfilter/nf_conntrack_irc.c | 12 +++--
net/netfilter/nf_conntrack_sane.c | 68 ++++++++++++--------------
4 files changed, 54 insertions(+), 60 deletions(-)
--
2.35.1
next reply other threads:[~2022-08-09 13:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 13:16 Florian Westphal [this message]
2022-08-09 13:16 ` [PATCH nf 1/4] netfilter: conntrack: sane: remove pseudo skb linearization Florian Westphal
2022-08-09 13:16 ` [PATCH nf 2/4] netfilter: conntrack: h323: cap packet size at 64k Florian Westphal
2022-08-09 13:16 ` [PATCH nf 3/4] netfilter: conntrack_ftp: prefer skb_linearize Florian Westphal
2022-08-09 15:36 ` Alexander Duyck
2022-08-09 16:07 ` Florian Westphal
2022-08-09 16:54 ` Alexander Duyck
2022-08-09 22:38 ` Florian Westphal
2022-08-09 13:16 ` [PATCH nf 4/4] netfilter: conntrack_irc: cap packet search space to 4k Florian Westphal
2022-08-11 14:41 ` [PATCH nf 0/4] netfilter: conntrack: remove 64kb max size assumptions Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220809131635.3376-1-fw@strlen.de \
--to=fw@strlen.de \
--cc=alexanderduyck@fb.com \
--cc=edumazet@google.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).