> On 3 Dec 2019, at 16:06, Kevin Darbyshire-Bryant wrote: > > set-dscpmark is a method of storing the DSCP of an ip packet into > conntrack mark. In combination with a suitable tc filter action > (act_ctinfo) DSCP values are able to be stored in the mark on egress and > restored on ingress across links that otherwise alter or bleach DSCP. > Well no one has yet screamed. I do think I’ve done this wrong: > > +enum { > + XT_CONNMARK_VALUE = BIT(0), > + XT_CONNMARK_DSCP = BIT(1) > +}; and they should be = (1 << bit_number) instead. I’ll send a v2 with that change (to nf-next) but anything else? or is it all too horrid to contemplate :-) Cheers, Kevin