netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Duncan Roe <duncan_roe@optusnet.com.au>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Netfilter Development <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH RFC libnetfilter_queue 0/1] Eliminate packet copy when constructing struct pkt_buff
Date: Mon, 31 May 2021 13:11:26 +1000	[thread overview]
Message-ID: <YLRT3kDFMv7jj3Et@slk1.local.net> (raw)
In-Reply-To: <20210504023431.19358-1-duncan_roe@optusnet.com.au>

Hi Pablo,

On Tue, May 04, 2021 at 12:34:30PM +1000, Duncan Roe wrote:
> Hi Pablo,
>
> This is item 2 of 4 after which I think we could do a new release.
>
> Item 3 is to eliminate packet copy when returning a mangled packet
> in a verdict.
> I have this working in inline code, not yet factored into function calls.
>
[SNIP]

I have abandoned item 3. Timing tests showed sendmsg() of 3 or 4 buffers to be
slower than memcpy() them into 1 buf and send that (i.e. use
nfq_nlmsg_verdict_put_pkt() and mnl_socket_sendto()).

Instead, I'll take a look at stopping the automatic load of libnfnetlink, as we
discussed a while back.

Cheers ... Duncan.

      parent reply	other threads:[~2021-05-31  3:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-04  2:34 [PATCH RFC libnetfilter_queue 0/1] Eliminate packet copy when constructing struct pkt_buff Duncan Roe
2021-05-04  2:34 ` [PATCH RFC libnetfilter_queue 1/1] " Duncan Roe
2021-05-18  3:08   ` [PATCH libnetfilter_queue v2 0/1] Speed-up Duncan Roe
2021-05-18  3:08   ` [PATCH libnetfilter_queue v2 1/1] Eliminate packet copy when constructing struct pkt_buff Duncan Roe
2021-05-27 20:23     ` Pablo Neira Ayuso
2021-07-18  4:28       ` Duncan Roe
2021-08-04  1:38       ` Duncan Roe
2021-05-04  2:50 ` [PATCH RFC libnetfilter_queue 0/1] " Duncan Roe
2021-05-31  3:11 ` Duncan Roe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YLRT3kDFMv7jj3Et@slk1.local.net \
    --to=duncan_roe@optusnet.com.au \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).