From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
Cc: netfilter-devel@vger.kernel.org, kadlec@netfilter.org,
fw@strlen.de, stable@vger.kernel.org
Subject: Re: [PATCH 3/3] netfilter: nf_tables: do not allow RULE_ID to refer to another chain
Date: Tue, 9 Aug 2022 19:39:25 +0200 [thread overview]
Message-ID: <YvKbzc53xy+0Bh0B@salvia> (raw)
In-Reply-To: <20220809170148.164591-3-cascardo@canonical.com>
On Tue, Aug 09, 2022 at 02:01:48PM -0300, Thadeu Lima de Souza Cascardo wrote:
> When doing lookups for rules on the same batch by using its ID, a rule from
> a different chain can be used. If a rule is added to a chain but tries to
> be positioned next to a rule from a different chain, it will be linked to
> chain2, but the use counter on chain1 would be the one to be incremented.
>
> When looking for rules by ID, use the chain that was used for the lookup by
> name. The chain used in the context copied to the transaction needs to
> match that same chain. That way, struct nft_rule does not need to get
> enlarged with another member.
Series applied, thanks
prev parent reply other threads:[~2022-08-09 17:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 17:01 [PATCH 1/3] netfilter: nf_tables: do not allow SET_ID to refer to another table Thadeu Lima de Souza Cascardo
2022-08-09 17:01 ` [PATCH 2/3] netfilter: nf_tables: do not allow CHAIN_ID " Thadeu Lima de Souza Cascardo
2022-08-09 17:01 ` [PATCH 3/3] netfilter: nf_tables: do not allow RULE_ID to refer to another chain Thadeu Lima de Souza Cascardo
2022-08-09 17:39 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvKbzc53xy+0Bh0B@salvia \
--to=pablo@netfilter.org \
--cc=cascardo@canonical.com \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).