From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Ismael Luceno <iluceno@suse.de>
Cc: linux-kernel@vger.kernel.org, "Firo Yang" <firo.yang@suse.com>,
"Andreas Taschner" <andreas.taschner@suse.com>,
"Michal Kubeček" <mkubecek@suse.com>,
"Simon Horman" <horms@verge.net.au>,
"Julian Anastasov" <ja@ssi.bg>,
lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org,
netdev@vger.kernel.org, coreteam@netfilter.org
Subject: Re: [PATCH v3] ipvs: Fix checksumming on GSO of SCTP packets
Date: Thu, 25 Apr 2024 22:50:04 +0200 [thread overview]
Message-ID: <ZirB_Arz_4xKXG4s@calendula> (raw)
In-Reply-To: <20240425162842.23900-1-iluceno@suse.de>
Hi,
On Thu, Apr 25, 2024 at 06:28:40PM +0200, Ismael Luceno wrote:
> It was observed in the wild that pairs of consecutive packets would leave
> the IPVS with the same wrong checksum, and the issue only went away when
> disabling GSO.
>
> IPVS needs to avoid computing the SCTP checksum when using GSO.
This patch went already upstream.
It was no clear to me that a v3 was needed.
You will have to post a follow up.
prev parent reply other threads:[~2024-04-25 20:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 16:28 [PATCH v3] ipvs: Fix checksumming on GSO of SCTP packets Ismael Luceno
2024-04-25 17:18 ` Julian Anastasov
2024-04-25 17:23 ` Jakub Kicinski
2024-04-25 20:50 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZirB_Arz_4xKXG4s@calendula \
--to=pablo@netfilter.org \
--cc=andreas.taschner@suse.com \
--cc=coreteam@netfilter.org \
--cc=firo.yang@suse.com \
--cc=horms@verge.net.au \
--cc=iluceno@suse.de \
--cc=ja@ssi.bg \
--cc=linux-kernel@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=mkubecek@suse.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).