netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jozsef Kadlecsik <kadlec@netfilter.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>, Greg KH <greg@kroah.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	netfilter-devel@vger.kernel.org,
	David Miller <davem@davemloft.net>,
	netdev@vger.kernel.org
Subject: Re: [PATCH 1/6] netfilter: ipset: fix suspicious RCU usage in find_set_and_id
Date: Sat, 1 Feb 2020 22:11:04 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.2002012207290.32505@blackhole.kfki.hu> (raw)
In-Reply-To: <20200201130549.3ee9a6b7@cakuba.hsd1.ca.comcast.net>

[-- Attachment #1: Type: text/plain, Size: 1936 bytes --]

On Sat, 1 Feb 2020, Jakub Kicinski wrote:

> On Sat, 1 Feb 2020 12:57:36 -0800, Jakub Kicinski wrote:
> > On Fri, 31 Jan 2020 20:24:23 +0100, Pablo Neira Ayuso wrote:
> > > From: Kadlecsik József <kadlec@blackhole.kfki.hu>
> > > 
> > > find_set_and_id() is called when the NFNL_SUBSYS_IPSET mutex is held.
> > > However, in the error path there can be a follow-up recvmsg() without
> > > the mutex held. Use the start() function of struct netlink_dump_control
> > > instead of dump() to verify and report if the specified set does not
> > > exist.
> > > 
> > > Thanks to Pablo Neira Ayuso for helping me to understand the subleties
> > > of the netlink protocol.
> > > 
> > > Reported-by: syzbot+fc69d7cb21258ab4ae4d@syzkaller.appspotmail.com
> > > Signed-off-by: Jozsef Kadlecsik <kadlec@netfilter.org>
> > > Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>  
> > 
> > This will trigger a missing signed-off-by check:
> > 
> > Commit 5038517119d5 ("netfilter: ipset: fix suspicious RCU usage in find_set_and_id")
> > 	author Signed-off-by missing
> > 	author email:    kadlec@blackhole.kfki.hu
> > 	committer email: pablo@netfilter.org
> > 	Signed-off-by: Jozsef Kadlecsik <kadlec@netfilter.org>
> > 	Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> > 
> > Problem is that the name differs by 'o' vs 'ó' (József Kadlecsik).
> > 
> > I wonder if it's worth getting rid of diacritics for the comparison..
> 
> Mm.. also the name and surname are the other way around :S

Oh, my... Hungarian names... :-) But I also should set my sender email 
address to kadlec@netfilter.org.

What's the best approach for this patch? Shall I resend it?

Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics
          H-1525 Budapest 114, POB. 49, Hungary

  reply	other threads:[~2020-02-01 21:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-31 19:24 [PATCH 0/6] Netfilter fixes for net Pablo Neira Ayuso
2020-01-31 19:24 ` [PATCH 1/6] netfilter: ipset: fix suspicious RCU usage in find_set_and_id Pablo Neira Ayuso
2020-02-01 20:57   ` Jakub Kicinski
2020-02-01 21:05     ` Jakub Kicinski
2020-02-01 21:11       ` Jozsef Kadlecsik [this message]
2020-02-02  4:21         ` Jakub Kicinski
2020-01-31 19:24 ` [PATCH 2/6] netfilter: Use kvcalloc Pablo Neira Ayuso
2020-01-31 19:24 ` [PATCH 3/6] netfilter: flowtable: Fix hardware flush order on nf_flow_table_cleanup Pablo Neira Ayuso
2020-01-31 19:24 ` [PATCH 4/6] netfilter: flowtable: Fix missing flush hardware on table free Pablo Neira Ayuso
2020-01-31 19:24 ` [PATCH 5/6] netfilter: flowtable: Fix setting forgotten NF_FLOW_HW_DEAD flag Pablo Neira Ayuso
2020-01-31 19:24 ` [PATCH 6/6] netfilter: nf_flowtable: fix documentation Pablo Neira Ayuso
2020-02-01 20:59 ` [PATCH 0/6] Netfilter fixes for net Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.2002012207290.32505@blackhole.kfki.hu \
    --to=kadlec@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=greg@kroah.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).