From: Julian Anastasov <ja@ssi.bg>
To: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Pablo Neira Ayuso <pablo@netfilter.org>,
netdev@vger.kernel.org, lvs-devel@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
netfilter-devel@vger.kernel.org,
Simon Horman <horms@verge.net.au>
Subject: Re: [PATCH v2 0/2] ipvs: speedup ipvs netns dismantle
Date: Mon, 30 Sep 2019 22:08:23 +0300 (EEST) [thread overview]
Message-ID: <alpine.LFD.2.21.1909302205360.2706@ja.home.ssi.bg> (raw)
In-Reply-To: <1569560091-20553-1-git-send-email-yanhaishuang@cmss.chinamobile.com>
Hello,
On Fri, 27 Sep 2019, Haishuang Yan wrote:
> Implement exit_batch() method to dismantle more ipvs netns
> per round.
>
> Tested:
> $ cat add_del_unshare.sh
> #!/bin/bash
>
> for i in `seq 1 100`
> do
> (for j in `seq 1 40` ; do unshare -n ipvsadm -A -t 172.16.$i.$j:80 >/dev/null ; done) &
> done
> wait; grep net_namespace /proc/slabinfo
>
> Befor patch:
> $ time sh add_del_unshare.sh
> net_namespace 4020 4020 4736 6 8 : tunables 0 0 0 : slabdata 670 670 0
>
> real 0m8.086s
> user 0m2.025s
> sys 0m36.956s
>
> After patch:
> $ time sh add_del_unshare.sh
> net_namespace 4020 4020 4736 6 8 : tunables 0 0 0 : slabdata 670 670 0
>
> real 0m7.623s
> user 0m2.003s
> sys 0m32.935s
>
> Haishuang Yan (2):
> ipvs: batch __ip_vs_cleanup
> ipvs: batch __ip_vs_dev_cleanup
>
> include/net/ip_vs.h | 2 +-
> net/netfilter/ipvs/ip_vs_core.c | 47 ++++++++++++++++++++++++-----------------
> net/netfilter/ipvs/ip_vs_ctl.c | 12 ++++++++---
> 3 files changed, 38 insertions(+), 23 deletions(-)
Both patches in v2 look good to me, thanks!
Acked-by: Julian Anastasov <ja@ssi.bg>
This is for the -next kernels...
Regards
--
Julian Anastasov <ja@ssi.bg>
next prev parent reply other threads:[~2019-09-30 20:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 4:54 [PATCH v2 0/2] ipvs: speedup ipvs netns dismantle Haishuang Yan
2019-09-27 4:54 ` [PATCH v2 1/2] ipvs: batch __ip_vs_cleanup Haishuang Yan
2019-09-27 4:54 ` [PATCH v2 2/2] ipvs: batch __ip_vs_dev_cleanup Haishuang Yan
2019-09-30 19:08 ` Julian Anastasov [this message]
2019-10-01 9:54 ` [PATCH v2 0/2] ipvs: speedup ipvs netns dismantle Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.1909302205360.2706@ja.home.ssi.bg \
--to=ja@ssi.bg \
--cc=davem@davemloft.net \
--cc=horms@verge.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=yanhaishuang@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).