From: Edward Cree <ecree@solarflare.com>
To: Jiri Pirko <jiri@resnulli.us>, Jakub Kicinski <kuba@kernel.org>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>, <netdev@vger.kernel.org>,
<davem@davemloft.net>, <netfilter-devel@vger.kernel.org>
Subject: Re: [RFC PATCH net] net: flow_offload: simplify hw stats check handling
Date: Mon, 11 May 2020 11:09:44 +0100 [thread overview]
Message-ID: <cc715ede-ce75-39ca-4887-4c1d208b4c1f@solarflare.com> (raw)
In-Reply-To: <20200511053359.GC2245@nanopsycho>
On 11/05/2020 06:33, Jiri Pirko wrote:
> Fri, May 08, 2020 at 01:48:20AM CEST, kuba@kernel.org wrote:
>> On Thu, 7 May 2020 18:46:43 +0200 Pablo Neira Ayuso wrote:
>>> Jiri said Disabled means: bail out if you cannot disable it.
>> That's in TC uAPI Jiri chose... doesn't mean we have to do the same
>> internally.
> Yeah, but if TC user says "disabled", please don't assign counter or
> fail.
Right, that's what happens with my proposal: TC "disabled" gets
mapped to internal "disabled (and no other bits)", which means
"disable or fail". In exactly the same way that TC "immediate"
gets mapped to internal "immediate (and no other bits)" which
means "immediate or fail".
As Jakub says, "What could be simpler?"
-ed
next prev parent reply other threads:[~2020-05-11 10:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 14:59 [RFC PATCH net] net: flow_offload: simplify hw stats check handling Edward Cree
2020-05-07 15:32 ` Pablo Neira Ayuso
2020-05-07 15:49 ` Edward Cree
2020-05-07 16:46 ` Pablo Neira Ayuso
2020-05-07 23:48 ` Jakub Kicinski
2020-05-11 5:33 ` Jiri Pirko
2020-05-11 10:09 ` Edward Cree [this message]
2020-05-07 15:36 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc715ede-ce75-39ca-4887-4c1d208b4c1f@solarflare.com \
--to=ecree@solarflare.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).