From: wenxu <wenxu@ucloud.cn>
To: netfilter-devel@vger.kernel.org
Subject: flowtable crash in nf_flow_table_indr_block_cb
Date: Sun, 5 Apr 2020 11:28:00 +0800 [thread overview]
Message-ID: <db9dfe4f-62e7-241b-46a0-d878c89696a8@ucloud.cn> (raw)
In-Reply-To: <2d1dd983-bc7c-7e8d-965d-0ec7d9716c1a@ucloud.cn>
Hi Pablo,
Flowtable will crash in nf_flow_table_indr_block_cb when the nf_tables
modules is not in.
# modprobe act_ct
The act_ct will auto load the flowtable modules.
# ip l a dev gre type gretap external.
nf_flow_table_indr_block_cb will crash for the uninit in net->nft.tables.
I thinkthe following patch is not good a solution indeely
http://patchwork.ozlabs.org/patch/1257422/
The flowtable can be used by both nf_tables and act_ct.
But the nf_flow_table_indr_block_cb in flow_indr_block_entry
only be used for nf_tables. So move the flow_indr_add_block_cb
to the nf_tables modules is a better solution? such as nf_tables_offload.c
or a new nf_flow_table_indr_offload.c?
And the flowtable modules don't need to include the nf_tables.h
BR
wenxu
parent reply other threads:[~2020-04-05 3:29 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <2d1dd983-bc7c-7e8d-965d-0ec7d9716c1a@ucloud.cn>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db9dfe4f-62e7-241b-46a0-d878c89696a8@ucloud.cn \
--to=wenxu@ucloud.cn \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).