From: Jan Engelhardt <jengelh@inai.de>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: Netfilter Devel <netfilter-devel@vger.kernel.org>,
Duncan Roe <duncan_roe@optusnet.com.au>,
Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH libmnl] libmnl: add support for signed types
Date: Fri, 5 Aug 2022 01:35:45 +0200 (CEST) [thread overview]
Message-ID: <q7301nr-3q5r-q54s-o9o7-r19104226p3@vanv.qr> (raw)
In-Reply-To: <20220804220555.2681949-1-jacob.e.keller@intel.com>
>+ * mnl_attr_get_s8 - returns 8-bit signed integer attribute payload
>+ *
>+ * This function returns the 8-bit value of the attribute payload.
>+ */
That's kinda redundant - it's logically the same thing, just written
ever-so-slightly differently.
>+/**
>+ * mnl_attr_get_s64 - returns 64-bit signed integer attribute.
> This
>+ * function is align-safe, since accessing 64-bit Netlink attributes is a
>+ * common source of alignment issues.
That sentence is self-defeating. If NLA access is a commn source of
alignment issues, then, by transitivity, this function too would
be potentially affected. Just
"This function reads the 64-bit nlattr in an alignment-safe manner."
next prev parent reply other threads:[~2022-08-04 23:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 22:05 [PATCH libmnl] libmnl: add support for signed types Jacob Keller
2022-08-04 23:35 ` Jan Engelhardt [this message]
2022-08-05 0:05 ` Keller, Jacob E
2022-08-05 0:46 ` Duncan Roe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=q7301nr-3q5r-q54s-o9o7-r19104226p3@vanv.qr \
--to=jengelh@inai.de \
--cc=duncan_roe@optusnet.com.au \
--cc=jacob.e.keller@intel.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).