Re: [Nouveau] [PATCH v2 06/22] drm/malidp: Don't set struct drm_device.irq_enabled

From: Liviu Dudau <liviu.dudau@arm.com>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: heiko@sntech.de, emma@anholt.net, airlied@linux.ie,
	nouveau@lists.freedesktop.org, alexandre.torgue@foss.st.com,
	dri-devel@lists.freedesktop.org, michal.simek@xilinx.com,
	linux-tegra@vger.kernel.org, thierry.reding@gmail.com,
	laurent.pinchart@ideasonboard.com, benjamin.gaignard@linaro.org,
	mihail.atanassov@arm.com, festevam@gmail.com,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-samsung-soc@vger.kernel.org, jy0922.shim@samsung.com,
	krzysztof.kozlowski@canonical.com,
	linux-rockchip@lists.infradead.org,
	linux-mediatek@lists.infradead.org, wens@csie.org,
	jernej.skrabec@gmail.com, xinliang.liu@linaro.org,
	kong.kongxinwei@hisilicon.com, james.qian.wang@arm.com,
	linux-imx@nxp.com, linux-graphics-maintainer@vmware.com,
	linux-sunxi@lists.linux.dev, bskeggs@redhat.com,
	chunkuang.hu@kernel.org, p.zabel@pengutronix.de,
	puck.chen@hisilicon.com, s.hauer@pengutronix.de,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	inki.dae@samsung.com, john.stultz@linaro.org,
	laurentiu.palcu@oss.nxp.com, matthias.bgg@gmail.com,
	kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org,
	mcoquelin.stm32@gmail.com, amd-gfx@lists.freedesktop.org,
	hyun.kwon@xilinx.com, tomba@kernel.org, jyri.sarha@iki.fi,
	yannick.fertre@foss.st.com, Xinhui.Pan@amd.com,
	sw0312.kim@samsung.com, hjc@rock-chips.com,
	christian.koenig@amd.com, kyungmin.park@samsung.com,
	philippe.cornu@foss.st.com, daniel@ffwll.ch,
	alexander.deucher@amd.com, tiantao6@hisilicon.com,
	shawnguo@kernel.org, brian.starkey@arm.com, zackr@vmware.com,
	l.stach@pengutronix.de
Subject: Re: [Nouveau] [PATCH v2 06/22] drm/malidp: Don't set struct drm_device.irq_enabled
Date: Tue, 22 Jun 2021 16:26:32 +0100	[thread overview]
Message-ID: <20210622152632.647akpp5nqcdfozk@e110455-lin.cambridge.arm.com> (raw)
In-Reply-To: <20210622141002.11590-7-tzimmermann@suse.de>

On Tue, Jun 22, 2021 at 04:09:46PM +0200, Thomas Zimmermann wrote:
> The field drm_device.irq_enabled is only used by legacy drivers
> with userspace modesetting. Don't set it in malidp.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>

Acked-by: Liviu Dudau <liviu.dudau@arm.com>

Best regards,
Liviu

> ---
>  drivers/gpu/drm/arm/malidp_drv.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
> index de59f3302516..78d15b04b105 100644
> --- a/drivers/gpu/drm/arm/malidp_drv.c
> +++ b/drivers/gpu/drm/arm/malidp_drv.c
> @@ -847,8 +847,6 @@ static int malidp_bind(struct device *dev)
>  	if (ret < 0)
>  		goto irq_init_fail;
>  
> -	drm->irq_enabled = true;
> -
>  	ret = drm_vblank_init(drm, drm->mode_config.num_crtc);
>  	if (ret < 0) {
>  		DRM_ERROR("failed to initialise vblank\n");
> @@ -874,7 +872,6 @@ static int malidp_bind(struct device *dev)
>  vblank_fail:
>  	malidp_se_irq_fini(hwdev);
>  	malidp_de_irq_fini(hwdev);
> -	drm->irq_enabled = false;
>  irq_init_fail:
>  	drm_atomic_helper_shutdown(drm);
>  	component_unbind_all(dev, drm);
> @@ -909,7 +906,6 @@ static void malidp_unbind(struct device *dev)
>  	drm_atomic_helper_shutdown(drm);
>  	malidp_se_irq_fini(hwdev);
>  	malidp_de_irq_fini(hwdev);
> -	drm->irq_enabled = false;
>  	component_unbind_all(dev, drm);
>  	of_node_put(malidp->crtc.port);
>  	malidp->crtc.port = NULL;
> -- 
> 2.32.0
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau