From: Ben Skeggs <skeggsb@gmail.com>
To: nouveau@lists.freedesktop.org
Cc: Ben Skeggs <bskeggs@redhat.com>
Subject: [Nouveau] [PATCH 01/10] drm/nouveau/nvkm: fini object children in reverse order
Date: Thu, 25 May 2023 10:30:57 +1000 [thread overview]
Message-ID: <20230525003106.3853741-1-skeggsb@gmail.com> (raw)
From: Ben Skeggs <bskeggs@redhat.com>
Turns out, we're currently tearing down the disp core channel *before*
the satellite channels (wndw, etc) during suspend.
This makes RM return NV_ERR_NOT_SUPPORTED on attempting to reallocate
the core channel on resume for some reason, but we probably shouldn't
be doing it on HW either.
Tear down children in the reverse of allocation order instead.
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
---
drivers/gpu/drm/nouveau/nvkm/core/object.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/core/object.c b/drivers/gpu/drm/nouveau/nvkm/core/object.c
index 301a5e5b5f7f..7c554c14e884 100644
--- a/drivers/gpu/drm/nouveau/nvkm/core/object.c
+++ b/drivers/gpu/drm/nouveau/nvkm/core/object.c
@@ -185,7 +185,7 @@ nvkm_object_fini(struct nvkm_object *object, bool suspend)
nvif_debug(object, "%s children...\n", action);
time = ktime_to_us(ktime_get());
- list_for_each_entry(child, &object->tree, head) {
+ list_for_each_entry_reverse(child, &object->tree, head) {
ret = nvkm_object_fini(child, suspend);
if (ret && suspend)
goto fail_child;
--
2.40.1
next reply other threads:[~2023-05-25 0:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 0:30 Ben Skeggs [this message]
2023-05-25 0:30 ` [Nouveau] [PATCH 02/10] drm/nouveau/nvkm: punt spurious irq messages to debug level Ben Skeggs
2023-06-13 21:26 ` Karol Herbst
2023-05-25 0:30 ` [Nouveau] [PATCH 03/10] drm/nouveau/fb/gp102-ga100: switch to simpler vram size detection method Ben Skeggs
2023-06-13 21:29 ` Karol Herbst
2023-05-25 0:31 ` [Nouveau] [PATCH 04/10] drm/nouveau/fb/ga102-: construct vidmem heap via new gp102 paths Ben Skeggs
2023-05-25 0:31 ` [Nouveau] [PATCH 05/10] drm/nouveau/fifo: remove left-over references to nvkm_fifo_chan Ben Skeggs
2023-06-13 21:32 ` Karol Herbst
2023-05-25 0:31 ` [Nouveau] [PATCH 06/10] drm/nouveau/fifo: return ERR_PTR from nvkm_runl_new() Ben Skeggs
2023-06-13 21:32 ` Karol Herbst
2023-05-25 0:31 ` [Nouveau] [PATCH 07/10] drm/nouveau/fifo/ga100-: remove individual runlists rather than failing oneinit Ben Skeggs
2023-06-13 21:35 ` Karol Herbst
2023-05-25 0:31 ` [Nouveau] [PATCH 08/10] drm/nouveau/fifo/ga100-: add per-runlist nonstall intr handling Ben Skeggs
2023-06-13 21:41 ` Karol Herbst
2023-05-25 0:31 ` [Nouveau] [PATCH 09/10] drm/nouveau/nvif: fix potential double-free Ben Skeggs
2023-06-13 21:44 ` Karol Herbst
2023-05-25 0:31 ` [Nouveau] [PATCH 10/10] drm/nouveau/kms: don't call drm_dp_cec_set_edid() on TMDS Ben Skeggs
2023-06-13 21:44 ` Karol Herbst
2023-06-13 21:26 ` [Nouveau] [PATCH 01/10] drm/nouveau/nvkm: fini object children in reverse order Karol Herbst
2023-06-13 21:52 ` Lyude Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230525003106.3853741-1-skeggsb@gmail.com \
--to=skeggsb@gmail.com \
--cc=bskeggs@redhat.com \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).