Re: [PATCH] [v7] nouveau: add command-line GSP-RM registry support

From: Timur Tabi <ttabi@nvidia.com>
To: "dakr@redhat.com" <dakr@redhat.com>
Cc: "airlied@redhat.com" <airlied@redhat.com>,
	"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
	"lyude@redhat.com" <lyude@redhat.com>,
	Ben Skeggs <bskeggs@nvidia.com>
Subject: Re: [PATCH] [v7] nouveau: add command-line GSP-RM registry support
Date: Thu, 25 Apr 2024 16:38:19 +0000	[thread overview]
Message-ID: <913052ca6c0988db1bab293cfae38529251b4594.camel@nvidia.com> (raw)
In-Reply-To: <162ef3c0-1d7b-4220-a21f-b0008657f8a5@redhat.com>

On Thu, 2024-04-25 at 15:22 +0200, Danilo Krummrich wrote:
> > +		size_t length;
> > +
> > +		/* Remove any whitespace from the parameter string */
> > +		length = strip(p, " \t\n");
> 
> With that, I see the following warning compiling this patch.
> 
> warning: variable ‘length’ set but not used [-Wunused-but-set-variable]
> 
> Did you intend to use the length for anything?

No, and I could have sworn I fixed that before sending out v7.  I think I
originally intended 'length' to determine when I finished parsing the
string.

> Also, looking at the warning made me aware of 'p' potentially being NULL.
> 
> If you agree, I can fix the warning and add the corresponding NULL check
> when
> applying the patch.

Yes, that would be great.  You can just delete 'length'.  The NULL check for
'p' should call clean_registry() before returning -ENOMEM.

Thanks for catching this.