From: Alex Deucher <alexdeucher@gmail.com>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: tvrtko.ursulin@linux.intel.com, joonas.lahtinen@linux.intel.com,
dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
Xinhui.Pan@amd.com, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, jose.souza@intel.com,
jani.nikula@linux.intel.com, daniel@ffwll.ch,
rodrigo.vivi@intel.com, alexander.deucher@amd.com,
evan.quan@amd.com, christian.koenig@amd.com, bskeggs@redhat.com
Subject: Re: [Nouveau] [PATCH v3 0/3] drm/{amdgpu, i915, nouveau, radeon}: Fix fbdev and vga-switcheroo
Date: Mon, 16 Jan 2023 13:42:15 -0500 [thread overview]
Message-ID: <CADnq5_NvhCq0oo2hbTmeTTiusubLGc7d-6zxnw_G_bMQg587Ew@mail.gmail.com> (raw)
In-Reply-To: <20230116115425.13484-1-tzimmermann@suse.de>
On Mon, Jan 16, 2023 at 6:54 AM Thomas Zimmermann <tzimmermann@suse.de> wrote:
>
> (was: drm: Generic fbdev and vga-switcheroo)
>
> This patchset fixes how fbdev helpers interact with vga-switcheroo. The
> first two patches are bug fixes for the existing code. The third patch
> cleans up the drivers.
>
> Patch 1 fixes i915 to do the correct thing if the device has not been
> initialized yet. Switching to the device is only possible after the
> initialization, but switching away is always possible.
>
> Patch 2 is the original patch without the amdgpu changes. Installs
> the fbdev framebuffer in vga-switcheroo for the PCI device. Does
> nothing for drivers without vga-switcheroo.
>
> Patch 3 cleans up vga_switcheroo_process_delayed_switch() in amdgpu
> and the other related drivers (i.e., i915, nouveau and radeon). The
> call is now located at the end of drm_lastclose() and drivers do not
> need their own lastclose helpers any longer.
>
> I kept the r-bs from v1, but patch 1 is entirely new and patch 3 has
> significantly grown in size.
Series is:
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
>
> v3:
> * include drm_fb_helper.h in radeon_drv.c
> v2:
> * expand to patch series
> * fix i915, nouveau and radeon
>
> Thomas Zimmermann (3):
> drm/i915: Allow switching away via vga-switcheroo if uninitialized
> drm/fb-helper: Set framebuffer for vga-switcheroo clients
> drm: Call vga_switcheroo_process_delayed_switch() in drm_lastclose
>
> drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 -
> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 --
> drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 13 -------------
> drivers/gpu/drm/drm_fb_helper.c | 8 ++++++++
> drivers/gpu/drm/drm_file.c | 3 +++
> drivers/gpu/drm/i915/i915_driver.c | 26 ++-----------------------
> drivers/gpu/drm/i915/i915_switcheroo.c | 6 +++++-
> drivers/gpu/drm/nouveau/nouveau_drm.c | 1 -
> drivers/gpu/drm/nouveau/nouveau_vga.c | 7 -------
> drivers/gpu/drm/nouveau/nouveau_vga.h | 1 -
> drivers/gpu/drm/radeon/radeon_drv.c | 3 ++-
> drivers/gpu/drm/radeon/radeon_drv.h | 1 -
> drivers/gpu/drm/radeon/radeon_kms.c | 18 -----------------
> drivers/gpu/vga/vga_switcheroo.c | 4 ++--
> 14 files changed, 22 insertions(+), 72 deletions(-)
>
>
> base-commit: 68d139b609a97a83e7c231189d4864aba4e1679b
> prerequisite-patch-id: 0aa359f6144c4015c140c8a6750be19099c676fb
> prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24
> prerequisite-patch-id: 3f204510fcbf9530d6540bd8e6128cce598988b6
> --
> 2.39.0
>
prev parent reply other threads:[~2023-01-16 18:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 11:54 [Nouveau] [PATCH v3 0/3] drm/{amdgpu, i915, nouveau, radeon}: Fix fbdev and vga-switcheroo Thomas Zimmermann
2023-01-16 11:54 ` [Nouveau] [PATCH v3 1/3] drm/i915: Allow switching away via vga-switcheroo if uninitialized Thomas Zimmermann
2023-01-16 11:54 ` [Nouveau] [PATCH v3 2/3] drm/fb-helper: Set framebuffer for vga-switcheroo clients Thomas Zimmermann
2023-01-16 11:54 ` [Nouveau] [PATCH v3 3/3] drm: Call vga_switcheroo_process_delayed_switch() in drm_lastclose Thomas Zimmermann
2023-01-16 18:42 ` Alex Deucher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_NvhCq0oo2hbTmeTTiusubLGc7d-6zxnw_G_bMQg587Ew@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=Xinhui.Pan@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bskeggs@redhat.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=evan.quan@amd.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=jose.souza@intel.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).