From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 525ECC433EF for ; Sat, 2 Oct 2021 09:14:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06BDD61B06 for ; Sat, 2 Oct 2021 09:14:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 06BDD61B06 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 71D696E835; Sat, 2 Oct 2021 09:14:22 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 021396E835 for ; Sat, 2 Oct 2021 09:14:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633166060; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VJ9RXJTGIQ7TnplzhbGhNK6unhn11194McWtsI39dY4=; b=VcVtSCtO/4xlbQeqCAeGEAOVwJD/wlSzMZ+wTr9r96Zz4NZ/qSbGHtpjuV5blUUbJ2S9vc O7YPoXCVLUX5CYO7aqBDqyV6mDl5xnQfiFSuaVtGlmjzT/0F5OpEE4lk+66ltafd0oFOAv 9GPCvJTKF7dZ1puo+DZVOSl/dWwLiSo= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-584-EuU0SvtdOX6uuCToKZ02kg-1; Sat, 02 Oct 2021 05:14:19 -0400 X-MC-Unique: EuU0SvtdOX6uuCToKZ02kg-1 Received: by mail-ed1-f72.google.com with SMTP id e21-20020a50a695000000b003daa0f84db2so12574432edc.23 for ; Sat, 02 Oct 2021 02:14:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VJ9RXJTGIQ7TnplzhbGhNK6unhn11194McWtsI39dY4=; b=QpUDbR4lZ8PVTHLa8N6aefCMAdOra9LbRRcOQEL4BNQxcu3cWj33PBwVHnlHEGaAFT UNPrF033gT2AQBoSBezjwpsBgqpwIb+GsIX9kxLXYw3x5Zz0o6hq7Yw38YlOqVBOonJx OmZQKpuzcPZpAH5bEuoaJKLzH9+n3pg16Rulrfd8N8eAsuKTgplhrTwwgmFHWTPhsXHZ ZN3nj9LjpTYB3fGaHs22nxaaPUGrjPdZuS0c+vjaN5A9tKi5A2N4450cA9yOtBxJk0XV 56ne6qCSn0CXb274h+9XFkPzcU8RqCLHo6kZPwP3o5ln86mr9Oe1EBFJZS7Pj+aVMM9s Dovg== X-Gm-Message-State: AOAM5325DTjgaiIm97/lNNHWo8uVtoLMPc8JvB1ed43U5dA0Aqt6W08f oxyWBuEd7D6DHDuUcNagqtS0FLYbvwv53m1rOosjr1vHGPbGpHL/L9PLwB9sKGcvRM7pkHWzpoZ X8poGHvH6CI0Vo9JCfNmzgqyXrklCcrJ01b6d3Q+dXvdzhRCa7mA7PU77YIstZWfng438e6WHUy sSWw== X-Received: by 2002:a17:906:2bd0:: with SMTP id n16mr3186265ejg.132.1633166057562; Sat, 02 Oct 2021 02:14:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw1WcknLHya1hGXb5KcKJOBaUIP1K0/AwOnuQKYVTxuWskWhkeiWUzh9k/0uLVoupeZjj/I0g== X-Received: by 2002:a17:906:2bd0:: with SMTP id n16mr3186232ejg.132.1633166057182; Sat, 02 Oct 2021 02:14:17 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id l23sm3882559ejn.15.2021.10.02.02.14.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Oct 2021 02:14:16 -0700 (PDT) To: Lyude Paul , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org References: <20211001225344.1752203-1-lyude@redhat.com> From: Hans de Goede Message-ID: Date: Sat, 2 Oct 2021 11:14:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20211001225344.1752203-1-lyude@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hdegoede@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Nouveau] [Intel-gfx] [PATCH v2 0/4] drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" Hi Lyude, On 10/2/21 12:53 AM, Lyude Paul wrote: > When I originally moved all of the VESA backlight code in i915 into DRM > helpers, one of the things I didn't have the hardware or time for > testing was machines that used a combination of PWM and DPCD in order to > control their backlights. This has since then caused some breakages and > resulted in us disabling DPCD backlight support on such machines. This > works fine, unless you have a machine that actually needs this > functionality for backlight controls to work at all. Additionally, we > will need to support PWM for when we start adding support for VESA's > product (as in the product of multiplication) control mode for better > brightness ranges. > > So - let's finally finish up implementing basic support for these types > of backlights to solve these problems in our DP helpers, along with > implementing support for this in i915. And since digging into this issue > solved the last questions we really had about probing backlights in i915 > for the most part, let's update some of the comments around that as > well! Backlight control is a topic which I'm reasonably familiar with, do you want me to review this series for you ? Regards, Hans > > Changes: > * Fixup docs > * Add patch to stop us from breaking nouveau > > Lyude Paul (4): > drm/i915: Add support for panels with VESA backlights with PWM > enable/disable > drm/nouveau/kms/nv50-: Explicitly check DPCD backlights for aux > enable/brightness > drm/dp, drm/i915: Add support for VESA backlights using PWM for > brightness control > drm/i915: Clarify probing order in intel_dp_aux_init_backlight_funcs() > > drivers/gpu/drm/drm_dp_helper.c | 75 +++++++++++------ > .../drm/i915/display/intel_dp_aux_backlight.c | 80 ++++++++++++++----- > drivers/gpu/drm/nouveau/nouveau_backlight.c | 5 +- > include/drm/drm_dp_helper.h | 7 +- > 4 files changed, 122 insertions(+), 45 deletions(-) >