From: Thomas Zimmermann <tzimmermann@suse.de>
To: Ye Bin <yebin10@huawei.com>,
bskeggs@redhat.com, airlied@linux.ie, daniel@ffwll.ch,
dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Cc: Hulk Robot <hulkci@huawei.com>
Subject: Re: [Nouveau] [PATCH] drm/nouveau: remove set but not used variable ‘pdev’ in nouveau_bios_init
Date: Wed, 3 Feb 2021 09:20:21 +0100 [thread overview]
Message-ID: <aa1dc788-bc47-ac8e-73a9-067be8b6ba7a@suse.de> (raw)
In-Reply-To: <20210123013014.3815870-1-yebin10@huawei.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 1325 bytes --]
Applied to drm-misc-next. Thanks for the patch!
Am 23.01.21 um 02:30 schrieb Ye Bin:
> Fix follow warning:
> drivers/gpu/drm/nouveau/nouveau_bios.c:2086:18: warning: variable ‘pdev’ set but not used [-Wunused-but-set-variable]
> struct pci_dev *pdev;
> ^~~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Ye Bin <yebin10@huawei.com>
> ---
> drivers/gpu/drm/nouveau/nouveau_bios.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c
> index 7cc683b8dc7a..e8c445eb1100 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bios.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
> @@ -2083,13 +2083,11 @@ nouveau_bios_init(struct drm_device *dev)
> {
> struct nouveau_drm *drm = nouveau_drm(dev);
> struct nvbios *bios = &drm->vbios;
> - struct pci_dev *pdev;
> int ret;
>
> /* only relevant for PCI devices */
> if (!dev_is_pci(dev->dev))
> return 0;
> - pdev = to_pci_dev(dev->dev);
>
> if (!NVInitVBIOS(dev))
> return -ENODEV;
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
prev parent reply other threads:[~2021-02-03 8:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 1:30 [PATCH] drm/nouveau: remove set but not used variable ‘pdev’ in nouveau_bios_init Ye Bin
2021-02-03 8:20 ` Thomas Zimmermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa1dc788-bc47-ac8e-73a9-067be8b6ba7a@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@linux.ie \
--cc=bskeggs@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hulkci@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=yebin10@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).