From: "Qi, Fuli" <qi.fuli@jp.fujitsu.com>
To: 'Vishal Verma' <vishal.l.verma@intel.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: RE: [ndctl PATCH 1/3] ndctl, monitor: Fix formatting for --log in the man page
Date: Wed, 15 Aug 2018 00:30:30 +0000 [thread overview]
Message-ID: <0DEDF3B159719A448A49EF0E7B11E3223DAA1493@g01jpexmbkw24> (raw)
In-Reply-To: <20180814230555.3498-1-vishal.l.verma@intel.com>
> -----Original Message-----
> From: Vishal Verma [mailto:vishal.l.verma@intel.com]
> Sent: Wednesday, August 15, 2018 8:06 AM
> To: linux-nvdimm@lists.01.org
> Cc: Vishal Verma <vishal.l.verma@intel.com>; Qi, Fuli/斉 福利
> <qi.fuli@jp.fujitsu.com>
> Subject: [ndctl PATCH 1/3] ndctl, monitor: Fix formatting for --log in the man page
>
> Change the --log option to be similar to other options-with-arguments, such as --map.
>
> Cc: QI Fuli <qi.fuli@jp.fujitsu.com>
> Fixes: 8d2d75f76f1e ("ndctl, monitor: set default log destination to syslog if...")
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
> ---
> Documentation/ndctl/ndctl-monitor.txt | 23 ++++++++++-------------
> 1 file changed, 10 insertions(+), 13 deletions(-)
>
> diff --git a/Documentation/ndctl/ndctl-monitor.txt
> b/Documentation/ndctl/ndctl-monitor.txt
> index 9a8d76b..363c398 100644
> --- a/Documentation/ndctl/ndctl-monitor.txt
> +++ b/Documentation/ndctl/ndctl-monitor.txt
> @@ -65,20 +65,17 @@ OPTIONS
> A 'namespaceX.Y' device name, or namespace region plus id tuple
> 'X.Y'.
>
> --l <file | syslog | standard>::
> ---log=<file | syslog | standard>::
> +-l::
> +--log=::
> Send log messages to the specified destination.
> -+
> ---
> -<file>::
> - Send log messages to specified <file>. When fopen() is not able
> - to open <file>, log messages will be forwarded to syslog.
> -syslog::
> - Send messages to syslog.
> -standard::
> - Send messages to standard output.
> ---
> -+
> + - "<file>":
> + Send log messages to specified <file>. When fopen() is not able
> + to open <file>, log messages will be forwarded to syslog.
> + - "syslog":
> + Send messages to syslog.
> + - "standard":
> + Send messages to standard output.
> +
Looks good to me.
Please feel free to add: Reviewed-by: QI Fuli <qi.fui@jp.fujitsu.com>
Thanks,
QI
> The default log destination is 'syslog' if "--daemon" is specified, otherwise 'standard'.
> Note that standard and relative path for <file> will not work if "--daemon" is specified.
> --
> 2.14.4
>
>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
prev parent reply other threads:[~2018-08-15 0:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-14 23:05 [ndctl PATCH 1/3] ndctl, monitor: Fix formatting for --log in the man page Vishal Verma
2018-08-14 23:05 ` [ndctl PATCH 2/3] ndctl, list: fix the verbosity level formatting " Vishal Verma
2018-08-14 23:05 ` [ndctl PATCH 3/3] ndctl, docs: Use asciidoctor by default Vishal Verma
2018-08-15 17:32 ` [ndctl PATCH v2] " Vishal Verma
2018-08-15 0:30 ` Qi, Fuli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0DEDF3B159719A448A49EF0E7B11E3223DAA1493@g01jpexmbkw24 \
--to=qi.fuli@jp.fujitsu.com \
--cc=linux-nvdimm@lists.01.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).