From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E969221F0DB1D for ; Thu, 29 Mar 2018 11:02:49 -0700 (PDT) Date: Thu, 29 Mar 2018 20:09:27 +0200 From: Christoph Hellwig Subject: Re: [PATCH v7 05/14] ext4, dax: introduce ext4_dax_aops Message-ID: <20180329180927.GA16055@lst.de> References: <152167302988.5268.4370226749268662682.stgit@dwillia2-desk3.amr.corp.intel.com> <152167305782.5268.13485258587227210521.stgit@dwillia2-desk3.amr.corp.intel.com> <20180329154035.lvsepjvt6vcplshw@quack2.suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180329154035.lvsepjvt6vcplshw@quack2.suse.cz> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Jan Kara Cc: Theodore Ts'o , linux-nvdimm@lists.01.org, david@fromorbit.com, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, Andreas Dilger , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, hch@lst.de List-ID: On Thu, Mar 29, 2018 at 05:40:35PM +0200, Jan Kara wrote: > So ext4_direct_IO() for IS_DAX() files will just bail out. So could you > just provide ext4_dax_direct_IO() which will bail out and use it here? With > a similar comment as in xfs_vm_direct_IO() that open still needs this > method set... Thanks! In fact a common noop_direct_IO might make sense. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm