From: Huaisheng Ye <yehs2007@zoho.com>
To: linux-nvdimm@lists.01.org, dan.j.williams@intel.com
Cc: axboe@kernel.dk, linux-s390@vger.kernel.org, snitzer@redhat.com,
chengnt@lenovo.com, linux-fsdevel@vger.kernel.org,
heiko.carstens@de.ibm.com, linux-kernel@vger.kernel.org,
willy@infradead.org, colyli@suse.de, bart.vanassche@wdc.com,
dm-devel@redhat.com, viro@zeniv.linux.org.uk,
gregkh@linuxfoundation.org, schwidefsky@de.ibm.com, jack@suse.cz,
agk@redhat.com
Subject: [PATCH v2 5/6] md/dm-writecache: Don't request pointer dummy_addr when not required
Date: Thu, 26 Jul 2018 00:28:48 +0800 [thread overview]
Message-ID: <20180725162849.8320-6-yehs2007@zoho.com> (raw)
In-Reply-To: <20180725162849.8320-1-yehs2007@zoho.com>
From: Huaisheng Ye <yehs1@lenovo.com>
Function persistent_memory_claim doesn't need to get local pointer
dummy_addr from direct_access. Using NULL instead of having to pass
in a useless local pointer that caller then just throw away.
Suggested-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Signed-off-by: Huaisheng Ye <yehs1@lenovo.com>
---
drivers/md/dm-writecache.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/md/dm-writecache.c b/drivers/md/dm-writecache.c
index 87107c9..9d79084 100644
--- a/drivers/md/dm-writecache.c
+++ b/drivers/md/dm-writecache.c
@@ -268,9 +268,8 @@ static int persistent_memory_claim(struct dm_writecache *wc)
i = 0;
do {
long daa;
- void *dummy_addr;
daa = dax_direct_access(wc->ssd_dev->dax_dev, i, p - i,
- &dummy_addr, &pfn);
+ NULL, &pfn);
if (daa <= 0) {
r = daa ? daa : -EINVAL;
goto err3;
--
1.8.3.1
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2018-07-25 16:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 16:28 [PATCH v2 0/6] kaddr and pfn can be NULL to ->direct_access() Huaisheng Ye
2018-07-25 16:28 ` [PATCH v2 1/6] libnvdimm, pmem: " Huaisheng Ye
2018-07-25 16:28 ` [PATCH v2 2/6] s390, dcssblk: " Huaisheng Ye
2018-07-28 4:07 ` [External] " Huaisheng HS1 Ye
2018-07-30 5:14 ` Martin Schwidefsky
2018-07-25 16:28 ` [PATCH v2 3/6] tools/testing/nvdimm: " Huaisheng Ye
2018-07-25 16:28 ` [PATCH v2 4/6] dax/super: Do not request a pointer kaddr when not required Huaisheng Ye
2018-07-25 16:28 ` Huaisheng Ye [this message]
2018-07-27 19:33 ` [PATCH v2 5/6] md/dm-writecache: Don't request pointer dummy_addr " Mike Snitzer
2018-07-25 16:28 ` [PATCH v2 6/6] filesystem-dax: Do not request kaddr and pfn " Huaisheng Ye
2018-07-25 17:23 ` [PATCH v2 0/6] kaddr and pfn can be NULL to ->direct_access() Ross Zwisler
2018-07-25 21:35 ` Dave Jiang
2018-07-26 1:29 ` [External] " Huaisheng HS1 Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180725162849.8320-6-yehs2007@zoho.com \
--to=yehs2007@zoho.com \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=chengnt@lenovo.com \
--cc=colyli@suse.de \
--cc=dan.j.williams@intel.com \
--cc=dm-devel@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-s390@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=snitzer@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).