From: Borislav Petkov <bp@alien8.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Tony Luck <tony.luck@intel.com>,
linux-edac@vger.kernel.org,
linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH v3 1/2] nfit, mce: only handle uncorrectable machine checks
Date: Wed, 20 Feb 2019 20:47:59 +0100 [thread overview]
Message-ID: <20190220194759.GH3447@zn.tnic> (raw)
In-Reply-To: <CAPcyv4hNq8TPVkrNwqZJHyfSg+JUHG6taS5pz0r6+xAa29NTag@mail.gmail.com>
On Wed, Feb 20, 2019 at 11:40:10AM -0800, Dan Williams wrote:
> There is a difference. NVDIMMs have local tracking of discovered
> poison, methods to scan for latent poison, and methods to clear. A CEC
> connection, iiuc, would seem an awkward fit. Awkward because what CEC
> enables is meant to be implemented natively in the hardware, and CEC
> seems to have no concept of the fact that errors can be repaired.
CEC is a leaky bucket of sorts which does call memory_failure_queue() in
the end. So we poison only those errors which report the same address
over and over again.
Correctable errors are by definition already repaired, i.e., corrected
so there's no need to do anything.
The way stuff is plumbed now is, all correctable errors go to the CEC so
NFIT doesn't see them, if CEC is enabled.
But the patch Jeff quoted already changed NFIT to ignore correctable
errors so I guess we don't have to do anything. And this is still needed
for the case where CEC is not enabled.
I'd say.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2019-02-20 19:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 0:37 [PATCH v3 1/2] nfit, mce: only handle uncorrectable machine checks Vishal Verma
2018-10-26 0:37 ` [PATCH v3 2/2] nfit, mce: validate the mce->addr before using it Vishal Verma
2018-11-06 14:51 ` Borislav Petkov
2018-11-06 16:20 ` Dan Williams
2018-11-06 17:53 ` Borislav Petkov
2018-11-06 18:02 ` Dan Williams
2018-11-06 18:07 ` Borislav Petkov
2019-02-20 18:59 ` [PATCH v3 1/2] nfit, mce: only handle uncorrectable machine checks Jeff Moyer
2019-02-20 19:18 ` Borislav Petkov
2019-02-20 19:26 ` Jeff Moyer
2019-02-20 19:39 ` Borislav Petkov
2019-02-20 19:40 ` Dan Williams
2019-02-20 19:47 ` Borislav Petkov [this message]
2019-02-21 16:11 ` Jeff Moyer
2019-02-21 17:09 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220194759.GH3447@zn.tnic \
--to=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).