From: Santosh Sivaraj <santosh@fossix.org>
To: "Verma, Vishal L" <vishal.l.verma@intel.com>,
"sbhat@linux.ibm.com" <sbhat@linux.ibm.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"harish@linux.ibm.com" <harish@linux.ibm.com>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"vaibhav@linux.ibm.com" <vaibhav@linux.ibm.com>
Subject: Re: [ndctl PATCH v3 2/4] test: Don't skip tests if nfit modules are missing
Date: Thu, 25 Mar 2021 11:38:00 +0530 [thread overview]
Message-ID: <87lfab22bj.fsf@santosiv.in.ibm.com> (raw)
In-Reply-To: <7467b623b77b4e7232433632d8b110490ca66473.camel@intel.com>
"Verma, Vishal L" <vishal.l.verma@intel.com> writes:
> On Fri, 2021-03-19 at 11:20 +0530, Santosh Sivaraj wrote:
>> "Verma, Vishal L" <vishal.l.verma@intel.com> writes:
>
> [..]
>
>> >
>> > fix multi line comment to the right formatting:
>> > /*
>> > * line 1, etc
>> > */
>> >
>>
>> Will fix that.
>>
>> > > + if (access("/sys/bus/acpi", F_OK) == -1) {
>> > > + if (errno == ENOENT)
>> > > + family = NVDIMM_FAMILY_PAPR;
>> > > + }
>> >
>> > Instead of a blind default, can we perform a similar check for presence of
>> > PAPR too?
>> >
>>
>> Yes, I wanted to do that, but there is no reliable way of check that; there is
>> no ofnode before module load, and there won't be any PAPR specific DT entries if
>> the platform is not Power.
>>
>> I also test the 'ndtest' module on x86 with NDCTL_TEST_FAMILY environment
>> variable. I can let the default be nfit_test (NVDIMM_FAMILY_INTEL) and only load
>> PAPR module when the environment variable is set. Thoughts?
>>
> The env variable seems reasonable to me. If there is ever a third
> 'family' adding tests, having an arbitrary default might be awkward.
> I may suggest - if acpi is detected, use NFIT. If env has something that
> is known, e.g. PAPR, use that. If env is unset or doesn't match anything
> we know about, then bail with an error message. Does that sound
> reasonable?
Yes, that sounds too to me. I will send in the next version soon.
Thanks for the review!
Thanks,
Santosh
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2021-03-25 6:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 7:46 [ndctl PATCH v3 1/4] libndctl: test enablement for non-nfit devices Santosh Sivaraj
2021-03-11 7:46 ` [ndctl PATCH v3 2/4] test: Don't skip tests if nfit modules are missing Santosh Sivaraj
2021-03-17 22:14 ` Verma, Vishal L
2021-03-19 5:50 ` Santosh Sivaraj
2021-03-24 20:06 ` Verma, Vishal L
2021-03-25 6:08 ` Santosh Sivaraj [this message]
2021-03-11 7:46 ` [ndctl PATCH v3 3/4] papr: Add support to parse save_fail flag for dimm Santosh Sivaraj
2021-03-17 22:18 ` Verma, Vishal L
2021-03-11 7:46 ` [ndctl PATCH v3 4/4] Use page size as alignment value Santosh Sivaraj
2021-03-17 22:08 ` [ndctl PATCH v3 1/4] libndctl: test enablement for non-nfit devices Verma, Vishal L
2021-03-19 5:54 ` Santosh Sivaraj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfab22bj.fsf@santosiv.in.ibm.com \
--to=santosh@fossix.org \
--cc=dan.j.williams@intel.com \
--cc=harish@linux.ibm.com \
--cc=linux-nvdimm@lists.01.org \
--cc=sbhat@linux.ibm.com \
--cc=vaibhav@linux.ibm.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).