From: Dan Williams <dan.j.williams@intel.com>
To: "Elliott, Robert (Persistent Memory)" <elliott@hpe.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH] ndctl, check-labels: correct check-labels message wording
Date: Wed, 3 Oct 2018 17:15:59 -0700 [thread overview]
Message-ID: <CAPcyv4gKt4Qfta9gSB2eidQsPT2DBp5-J2yKJr5ZhAQXh79KQQ@mail.gmail.com> (raw)
In-Reply-To: <20181003222901.44438-1-elliott@hpe.com>
On Wed, Oct 3, 2018 at 3:26 PM Robert Elliott <elliott@hpe.com> wrote:
>
> ndctl check-labels prints the number of labels, not the number of
> nmems. Changed the print for:
>
> $ ndctl check-labels nmem0 nmem1
> from:
> successfully verified 510 nmems
> to:
> successfully verified 510 nmem labels
Looks good to me.
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
>
> Signed-off-by: Robert Elliott <elliott@hpe.com>
> ---
> ndctl/dimm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ndctl/dimm.c b/ndctl/dimm.c
> index a4203f3..699ab57 100644
> --- a/ndctl/dimm.c
> +++ b/ndctl/dimm.c
> @@ -1147,7 +1147,7 @@ int cmd_check_labels(int argc, const char **argv, void *ctx)
> int count = dimm_action(argc, argv, ctx, action_check, base_options,
> "ndctl check-labels <nmem0> [<nmem1>..<nmemN>] [<options>]");
>
> - fprintf(stderr, "successfully verified %d nmem%s\n",
> + fprintf(stderr, "successfully verified %d nmem label%s\n",
> count >= 0 ? count : 0, count > 1 ? "s" : "");
> return count >= 0 ? 0 : EXIT_FAILURE;
> }
> --
> 2.14.4
>
> _______________________________________________
> Linux-nvdimm mailing list
> Linux-nvdimm@lists.01.org
> https://lists.01.org/mailman/listinfo/linux-nvdimm
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
prev parent reply other threads:[~2018-10-04 0:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 22:29 [PATCH] ndctl, check-labels: correct check-labels message wording Robert Elliott
2018-10-04 0:15 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4gKt4Qfta9gSB2eidQsPT2DBp5-J2yKJr5ZhAQXh79KQQ@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=elliott@hpe.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).