From: Alexander Duyck <alexander.h.duyck@linux.intel.com>
To: Dan Williams <dan.j.williams@intel.com>, linux-nvdimm@lists.01.org
Cc: kbuild test robot <lkp@intel.com>
Subject: Re: [PATCH] libnvdimm, label: Fix sparse warning
Date: Fri, 12 Oct 2018 07:44:05 -0700 [thread overview]
Message-ID: <a288568e-3dd8-f92a-19fc-b15a3cae7ddf@linux.intel.com> (raw)
In-Reply-To: <153930924180.1057750.14086655850300209980.stgit@dwillia2-desk3.amr.corp.intel.com>
On 10/11/2018 6:54 PM, Dan Williams wrote:
> The kbuild robot reports:
>
> drivers/nvdimm/label.c:500:32: warning: restricted __le32 degrades to integer
>
> ...read 'nslot' into a local u32.
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Cc: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
The change looks good to me.
Acked-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> ---
> drivers/nvdimm/label.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/nvdimm/label.c b/drivers/nvdimm/label.c
> index 7f03d117824f..750dbaa6ce82 100644
> --- a/drivers/nvdimm/label.c
> +++ b/drivers/nvdimm/label.c
> @@ -424,6 +424,7 @@ int nd_label_data_init(struct nvdimm_drvdata *ndd)
> struct nd_namespace_index *nsindex;
> unsigned int i;
> int rc = 0;
> + u32 nslot;
>
> if (ndd->data)
> return 0;
> @@ -495,9 +496,10 @@ int nd_label_data_init(struct nvdimm_drvdata *ndd)
>
> /* Determine starting offset for label data */
> offset = __le64_to_cpu(nsindex->labeloff);
> + nslot = __le32_to_cpu(nsindex->nslot);
>
> /* Loop through the free list pulling in any active labels */
> - for (i = 0; i < nsindex->nslot; i++, offset += ndd->nslabel_size) {
> + for (i = 0; i < nslot; i++, offset += ndd->nslabel_size) {
> size_t label_read_size;
>
> /* zero out the unused labels */
>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
prev parent reply other threads:[~2018-10-12 14:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 1:54 [PATCH] libnvdimm, label: Fix sparse warning Dan Williams
2018-10-12 14:44 ` Alexander Duyck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a288568e-3dd8-f92a-19fc-b15a3cae7ddf@linux.intel.com \
--to=alexander.h.duyck@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).