From: Dave Jiang <dave.jiang@intel.com>
To: Dan Williams <dan.j.williams@intel.com>, linux-nvdimm@lists.01.org
Cc: linux-acpi@vger.kernel.org
Subject: Re: [PATCH 4/6] nfit, address-range-scrub: introduce nfit_spa->ars_state
Date: Tue, 3 Apr 2018 08:31:22 -0700 [thread overview]
Message-ID: <c37b43b3-bcb7-b3a3-f7d7-cc0753843859@intel.com> (raw)
In-Reply-To: <152273078267.38372.2191145328822655057.stgit@dwillia2-desk3.amr.corp.intel.com>
On 4/2/2018 9:46 PM, Dan Williams wrote:
> In preparation for re-working the ARS implementation to better handle
> short vs long ARS runs, introduce nfit_spa->ars_state. For now this just
> replaces the nfit_spa->ars_required bit-field/flag, but going forward it
> will be used to track ARS completion and make short vs long ARS
> requests.
>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/acpi/nfit/core.c | 6 +++---
> drivers/acpi/nfit/nfit.h | 9 ++++++++-
> 2 files changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index 2a1fc3817a81..9ba60f58d929 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -2808,7 +2808,7 @@ static void acpi_nfit_async_scrub(struct acpi_nfit_desc *acpi_desc,
> unsigned int tmo = scrub_timeout;
> int rc;
>
> - if (!nfit_spa->ars_required || !nfit_spa->nd_region)
> + if (!test_bit(ARS_REQ, &nfit_spa->ars_state) || !nfit_spa->nd_region)
> return;
>
> rc = ars_start(acpi_desc, nfit_spa);
> @@ -3003,7 +3003,7 @@ static void acpi_nfit_scrub(struct work_struct *work)
> * register them now to make data available.
> */
> if (!nfit_spa->nd_region) {
> - nfit_spa->ars_required = 1;
> + set_bit(ARS_REQ, &nfit_spa->ars_state);
> acpi_nfit_register_region(acpi_desc, nfit_spa);
> }
> }
> @@ -3261,7 +3261,7 @@ int acpi_nfit_ars_rescan(struct acpi_nfit_desc *acpi_desc, u8 flags)
> if (nfit_spa_type(spa) != NFIT_SPA_PM)
> continue;
>
> - nfit_spa->ars_required = 1;
> + set_bit(ARS_REQ, &nfit_spa->ars_state);
> }
> acpi_desc->ars_start_flags = flags;
> queue_work(nfit_wq, &acpi_desc->work);
> diff --git a/drivers/acpi/nfit/nfit.h b/drivers/acpi/nfit/nfit.h
> index ac9c49463731..efb6c6bcde42 100644
> --- a/drivers/acpi/nfit/nfit.h
> +++ b/drivers/acpi/nfit/nfit.h
> @@ -117,10 +117,17 @@ enum nfit_dimm_notifiers {
> NFIT_NOTIFY_DIMM_HEALTH = 0x81,
> };
>
> +enum nfit_ars_state {
> + ARS_REQ,
> + ARS_DONE,
> + ARS_SHORT,
> + ARS_FAILED,
> +};
> +
> struct nfit_spa {
> struct list_head list;
> struct nd_region *nd_region;
> - unsigned int ars_required:1;
> + unsigned long ars_state;
> u32 clear_err_unit;
> u32 max_ars;
> struct acpi_nfit_system_address spa[0];
>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2018-04-03 15:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 4:46 [PATCH 0/6] nfit, address-range-scrub: rework and fixes Dan Williams
2018-04-03 4:46 ` [PATCH 1/6] nfit: fix region registration vs block-data-window ranges Dan Williams
2018-04-03 15:30 ` Dave Jiang
[not found] ` <152273076649.38372.8379231668189794225.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2018-04-06 20:05 ` Sasha Levin
2018-04-03 4:46 ` [PATCH 2/6] nfit, address-range-scrub: fix scrub in-progress reporting Dan Williams
2018-04-03 15:31 ` Dave Jiang
[not found] ` <152273077198.38372.11857145045474104173.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2018-04-06 20:05 ` Sasha Levin
2018-04-03 4:46 ` [PATCH 3/6] libnvdimm: add an api to cast a 'struct nd_region' to its 'struct device' Dan Williams
2018-04-03 15:31 ` Dave Jiang
2018-04-03 4:46 ` [PATCH 4/6] nfit, address-range-scrub: introduce nfit_spa->ars_state Dan Williams
2018-04-03 15:31 ` Dave Jiang [this message]
2018-04-03 4:46 ` [PATCH 5/6] nfit, address-range-scrub: rework and simplify ARS state machine Dan Williams
2018-04-03 15:29 ` Dave Jiang
2018-04-03 15:33 ` Dan Williams
2018-04-04 16:26 ` Kani, Toshi
2018-04-04 17:08 ` Dan Williams
2018-04-03 4:46 ` [PATCH 6/6] nfit, address-range-scrub: add module option to skip initial ars Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c37b43b3-bcb7-b3a3-f7d7-cc0753843859@intel.com \
--to=dave.jiang@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).