From: Jeff Moyer <jmoyer@redhat.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: linux-nvdimm@lists.01.org
Subject: Re: [PATCH] dax: add missing address_space_operations for device dax
Date: Thu, 13 Sep 2018 14:25:52 -0400 [thread overview]
Message-ID: <x49va79p83z.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <153662150977.27329.9768329787276305204.stgit@djiang5-desk3.ch.intel.com> (Dave Jiang's message of "Mon, 10 Sep 2018 16:18:29 -0700")
Dave Jiang <dave.jiang@intel.com> writes:
> With address_space_operations missing for device dax, namely the
> .set_page_dirty, we hit a kernel warning when running destructive
> ndctl unit test: make TESTS=device-dax check
>
> WARNING: CPU: 3 PID: 7380 at fs/buffer.c:581 __set_page_dirty+0xb1/0xc0
>
> Setting address_space_operations to noop_set_page_dirty and
> noop_invalidatepage for device dax to prevent fallback to
> __set_page_dirty_buffers() and block_invalidatepage() respectively.
>
> Fixes: 2232c6382a ("device-dax: Enable page_mapping()")
>
> Reported-by: Vishal Verma <vishal.l.verma@intel.com>
> Suggested-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
I looked over the other aops, and I think this covers the fallback
paths.
Acked-by: Jeff Moyer <jmoyer@redhat.com>
> ---
> drivers/dax/device.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/dax/device.c b/drivers/dax/device.c
> index 6fd46083e629..079f6811eca6 100644
> --- a/drivers/dax/device.c
> +++ b/drivers/dax/device.c
> @@ -534,6 +534,11 @@ static unsigned long dax_get_unmapped_area(struct file *filp,
> return current->mm->get_unmapped_area(filp, addr, len, pgoff, flags);
> }
>
> +static const struct address_space_operations dev_dax_aops = {
> + .set_page_dirty = noop_set_page_dirty,
> + .invalidatepage = noop_invalidatepage,
> +};
> +
> static int dax_open(struct inode *inode, struct file *filp)
> {
> struct dax_device *dax_dev = inode_dax(inode);
> @@ -543,6 +548,7 @@ static int dax_open(struct inode *inode, struct file *filp)
> dev_dbg(&dev_dax->dev, "trace\n");
> inode->i_mapping = __dax_inode->i_mapping;
> inode->i_mapping->host = __dax_inode;
> + inode->i_mapping->a_ops = &dev_dax_aops;
> filp->f_mapping = inode->i_mapping;
> filp->f_wb_err = filemap_sample_wb_err(filp->f_mapping);
> filp->private_data = dev_dax;
>
> _______________________________________________
> Linux-nvdimm mailing list
> Linux-nvdimm@lists.01.org
> https://lists.01.org/mailman/listinfo/linux-nvdimm
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
prev parent reply other threads:[~2018-09-13 18:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 23:18 [PATCH] dax: add missing address_space_operations for device dax Dave Jiang
2018-09-13 18:25 ` Jeff Moyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49va79p83z.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=dave.jiang@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).