From: Joseph Qi <joseph.qi@linux.alibaba.com>
To: Junxiao Bi <junxiao.bi@oracle.com>,
ocfs2-devel@oss.oracle.com, cluster-devel@redhat.com,
linux-fsdevel@vger.kernel.org, akpm <akpm@linux-foundation.org>
Subject: Re: [Ocfs2-devel] [PATCH 1/3] fs/buffer.c: add new api to allow eof writeback
Date: Thu, 29 Apr 2021 19:58:15 +0800 [thread overview]
Message-ID: <248885ce-6729-dc21-4937-849eb0fe8a45@linux.alibaba.com> (raw)
In-Reply-To: <20210426220552.45413-1-junxiao.bi@oracle.com>
On 4/27/21 6:05 AM, Junxiao Bi wrote:
> When doing truncate/fallocate for some filesytem like ocfs2, it
> will zero some pages that are out of inode size and then later
> update the inode size, so it needs this api to writeback eof
> pages.
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Junxiao Bi <junxiao.bi@oracle.com>
Looks good.
Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> ---
> fs/buffer.c | 14 +++++++++++---
> include/linux/buffer_head.h | 3 +++
> 2 files changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/fs/buffer.c b/fs/buffer.c
> index 0cb7ffd4977c..802f0bacdbde 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -1709,9 +1709,9 @@ static struct buffer_head *create_page_buffers(struct page *page, struct inode *
> * WB_SYNC_ALL, the writes are posted using REQ_SYNC; this
> * causes the writes to be flagged as synchronous writes.
> */
> -int __block_write_full_page(struct inode *inode, struct page *page,
> +int __block_write_full_page_eof(struct inode *inode, struct page *page,
> get_block_t *get_block, struct writeback_control *wbc,
> - bh_end_io_t *handler)
> + bh_end_io_t *handler, bool eof_write)
> {
> int err;
> sector_t block;
> @@ -1746,7 +1746,7 @@ int __block_write_full_page(struct inode *inode, struct page *page,
> * handle any aliases from the underlying blockdev's mapping.
> */
> do {
> - if (block > last_block) {
> + if (block > last_block && !eof_write) {
> /*
> * mapped buffers outside i_size will occur, because
> * this page can be outside i_size when there is a
> @@ -1871,6 +1871,14 @@ int __block_write_full_page(struct inode *inode, struct page *page,
> unlock_page(page);
> goto done;
> }
> +EXPORT_SYMBOL(__block_write_full_page_eof);
> +
> +int __block_write_full_page(struct inode *inode, struct page *page,
> + get_block_t *get_block, struct writeback_control *wbc,
> + bh_end_io_t *handler)
> +{
> + return __block_write_full_page_eof(inode, page, get_block, wbc, handler, false);
> +}
> EXPORT_SYMBOL(__block_write_full_page);
>
> /*
> diff --git a/include/linux/buffer_head.h b/include/linux/buffer_head.h
> index 6b47f94378c5..5da15a1ba15c 100644
> --- a/include/linux/buffer_head.h
> +++ b/include/linux/buffer_head.h
> @@ -221,6 +221,9 @@ int block_write_full_page(struct page *page, get_block_t *get_block,
> int __block_write_full_page(struct inode *inode, struct page *page,
> get_block_t *get_block, struct writeback_control *wbc,
> bh_end_io_t *handler);
> +int __block_write_full_page_eof(struct inode *inode, struct page *page,
> + get_block_t *get_block, struct writeback_control *wbc,
> + bh_end_io_t *handler, bool eof_write);
> int block_read_full_page(struct page*, get_block_t*);
> int block_is_partially_uptodate(struct page *page, unsigned long from,
> unsigned long count);
>
_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel
next prev parent reply other threads:[~2021-04-29 11:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 22:05 [Ocfs2-devel] [PATCH 1/3] fs/buffer.c: add new api to allow eof writeback Junxiao Bi
2021-04-26 22:05 ` [Ocfs2-devel] [PATCH 2/3] ocfs2: allow writing back pages out of inode size Junxiao Bi
2021-04-28 16:00 ` Junxiao Bi
2021-04-29 13:09 ` Joseph Qi
2021-04-26 22:05 ` [Ocfs2-devel] [PATCH 3/3] gfs2: fix out of inode size writeback Junxiao Bi
2021-04-28 16:02 ` Junxiao Bi
2021-04-29 11:58 ` Joseph Qi [this message]
2021-04-29 17:14 ` [Ocfs2-devel] [Cluster-devel] [PATCH 1/3] fs/buffer.c: add new api to allow eof writeback Andreas Gruenbacher
2021-04-29 18:07 ` Junxiao Bi
2021-04-30 12:47 ` Jan Kara
2021-04-30 21:18 ` Junxiao Bi
2021-05-03 10:29 ` Jan Kara
2021-05-03 17:25 ` Junxiao Bi
2021-05-04 9:02 ` Jan Kara
2021-05-04 23:35 ` Junxiao Bi
2021-05-05 11:43 ` Jan Kara
2021-05-05 15:54 ` Junxiao Bi
2021-05-09 23:23 ` [Ocfs2-devel] " Andrew Morton
2021-05-10 22:15 ` Junxiao Bi
2021-05-11 12:19 ` Bob Peterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=248885ce-6729-dc21-4937-849eb0fe8a45@linux.alibaba.com \
--to=joseph.qi@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=cluster-devel@redhat.com \
--cc=junxiao.bi@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).