From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Patrick Williams" <patrick@stwcx.xyz>,
"OpenBMC List" <openbmc@lists.ozlabs.org>
Subject: Re: xyz.openbmc_project.Sensor.Value units
Date: Wed, 30 Sep 2020 14:52:18 +0930 [thread overview]
Message-ID: <1e9909c8-90e7-4e66-b946-87924316f6f5@www.fastmail.com> (raw)
In-Reply-To: <20200921173326.GK6152@heinlein>
On Tue, 22 Sep 2020, at 03:03, Patrick Williams wrote:
> Hello,
>
> Currently all xyz.openbmc_project.Sensor.Value's have metric units.
> There is a proposed commit [1] to add a non-metric unit. Are there any
> opinions on this subject?
My opinion is we should convert values to presentation units at the
edges, and use metric everywhere internally.
>
> In this case the proposal is to add an "airflow" unit, in CFMs (cubit
> feet per minute). An equivalent metric unit would be L/s (liters per
> second). CFM tends to be the standard unit to measure airflow from a
> fan, but L/s is used for liquid cooling.
>
> Options:
>
> * Allow CFM for airflow.
> - CFM is the "industry standard" measurement for fans.
>
> * Require Sensors.Value to use L/s instead.
> - All units will continue to be metric. Any external interface
> which is expecting a non-metric unit can do the conversion at
> that point.
Right, so this is how it should be IMO.
>
> - We won't have duplicate Units defined for similar concepts
> (air vs liquid flow in this case).
>
> Thus, it seems like there are two underlying questions to resolve:
>
> * Do we require only metric unit or do we allow non-metric?
> * Do we allow duplicate unit definitions for the same concept (ex. flow)?
Lets avoid making life more confusing for ourselves and stick to a single
unit definition.
Andrew
prev parent reply other threads:[~2020-09-30 5:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 17:33 xyz.openbmc_project.Sensor.Value units Patrick Williams
2020-09-21 17:33 ` Patrick Williams
2020-09-30 5:22 ` Andrew Jeffery [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e9909c8-90e7-4e66-b946-87924316f6f5@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=openbmc@lists.ozlabs.org \
--cc=patrick@stwcx.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).