Would someone mind giving a 1-2 sentence explaination of what "sensor margin values" are? I'm certainly not a thermal control expert. I don't care if there are multiple implementations of similar functionality, but there is also work going on for a repository called 'phosphor-virtual-sensors'. What little I could understand of read-margin-temp's role seems to somewhat overlap with that effort. On Wed, Sep 16, 2020 at 10:37:14PM -0700, Josh Lehan wrote: > Yay, this is great to see. I have some bug fixes to read-margin-temp and > was just wondering how to contribute them. I'm really hoping this makes it > into OpenBMC. It's the perfect preprocessor for phosphor-pid-control, I > have found. > > Josh > > Josh Lehan | Software Engineer | krellan@google.com | +1 650-733-8941 > > > > On Wed, Sep 16, 2020 at 7:15 PM Benjamin Fair > wrote: > > > On Wed, 16 Sep 2020 at 06:31, Fran Hsu (徐誌謙) > > wrote: > > > > > > Hi Brad, > > > This is Fran from Quanta Computer. > > > Quanta OpenBMC team would like to share some useful tools to the OpenBMC > > community. > > > Such as the read-margin-temp daemon ( > > https://github.com/quanta-bmc/read-margin-temp), we are using this daemon > > to fill sensor margin value to PID to do fan control. > > > > read-margin-temp seems useful and widely applicable enough that I > > think it's worth having a dedicated repo for it. > > > > The quanta-misc repo could possibly be used for smaller, more > > Quanta-specific things. > > > > > > > > We would like to have a repo named "quanta-misc" under the OpenBMC > > github. > > > > > > Here is the maintainer list: > > > M: Benjamin Fair > > > M: Brandon Kim > > > M: Fran Hsu > > > M: George Hung > > > M: Buddy Huang > > > > > > Thank you. > > > Fran Hsu > > > E-Mail : Fran.Hsu@QuantaTW.com > > > Tel: +886-3-327-2345 Ext: 16935 <+886%203%20327%202345> > > > > > > > > -- Patrick Williams