openbmc.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Patrick Williams <patrick@stwcx.xyz>
To: "Velumani T-ERS,HCLTech" <velumanit@hcl.com>
Cc: "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
	Patrick Williams <patrickw3@fb.com>
Subject: Re: adding sync method in phosphor-time-manager
Date: Tue, 6 Oct 2020 20:34:46 -0500	[thread overview]
Message-ID: <20201007013446.GE6152@heinlein> (raw)
In-Reply-To: <PU1PR04MB2248961AEF87BA87C7749050A70D0@PU1PR04MB2248.apcprd04.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 1593 bytes --]

On Tue, Oct 06, 2020 at 05:38:13PM +0000, Velumani T-ERS,HCLTech wrote:
> Classification:
> Hi Team,
> 
> We wanted to add another time sync method in phosphor-time-manager to get the time from the host and set it to BMC. To have this option configurable I propose a dbus property in the time interface(given below). Please provide your feedback/comments.
> 
> https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/openbmc_project/Time/Synchronization.interface.yaml
> enumerations:
>     - name: Method
>       description: >
>         Possible methods of time synchronization.
>       values:
>         - name: NTP
>           description: >
>             Sync by using the Network Time Protocol.
>         - name: Manual
>           description: >
>             Sync time manually.
>          - name: HostSync
>           description: >
>             Sync the time from host.
> 

Hopefully Vishwa can weigh in here.

It is my understanding that the default implementation allows the host
to synchronize the time down already.  There use to be an interface that
determined the "TimeOwner" to specify if the BMC or the Host were in
charge of the time.  That was removed not too long ago.

https://github.com/openbmc/phosphor-dbus-interfaces/commit/70c76a29b898f05e28c803808bd57a2b6c3f7a6f

I think you should look through the history on this commit (it
references a discussion related to the mailing list) and check with the
people in that chain as to why it was removed before we add back in
something very similar.

-- 
Patrick Williams

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2020-10-07  1:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-06 17:38 adding sync method in phosphor-time-manager Velumani T-ERS,HCLTech
2020-10-06 21:41 ` Richard Hanley
2020-10-07  1:38   ` Patrick Williams
2020-10-07 17:18     ` Velumani T-ERS,HCLTech
2020-10-07  1:34 ` Patrick Williams [this message]
2021-04-08 18:08   ` Alexander Amelkin
2021-04-08 19:36     ` Ed Tanous
2021-04-09  7:26     ` Lei Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201007013446.GE6152@heinlein \
    --to=patrick@stwcx.xyz \
    --cc=openbmc@lists.ozlabs.org \
    --cc=patrickw3@fb.com \
    --cc=velumanit@hcl.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).