From: Zev Weiss <zev@bewilderbeest.net>
To: openbmc@lists.ozlabs.org
Cc: "Vignesh Raghavendra" <vigneshr@ti.com>,
"Zev Weiss" <zev@bewilderbeest.net>,
"Tudor Ambarus" <tudor.ambarus@microchip.com>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
"Richard Weinberger" <richard@nod.at>,
"Michael Walle" <michael@walle.cc>,
linux-mtd@lists.infradead.org, "Cédric Le Goater" <clg@kaod.org>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Jeremy Kerr" <jk@codeconstruct.com.au>,
linux-aspeed@lists.ozlabs.org, "Pratyush Yadav" <p.yadav@ti.com>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] mtd: spi-nor: aspeed: Don't automatically attach reserved chips
Date: Wed, 29 Sep 2021 04:54:07 -0700 [thread overview]
Message-ID: <20210929115409.21254-6-zev@bewilderbeest.net> (raw)
In-Reply-To: <20210929115409.21254-1-zev@bewilderbeest.net>
With this change, any flash chips under the controller that are marked
with a DT status of "reserved" will be created, but not automatically
attached. Userspace can later request that they be attached using the
attach_chip sysfs file.
This is to accommodate situations where a chip may be (for example)
shared with another controller external to the SoC and require
userspace to arbitrate access to it prior to actually attaching it.
(such as a firmware SPI flash shared between a BMC and the host
system).
Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
---
drivers/mtd/spi-nor/controllers/aspeed-smc.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/controllers/aspeed-smc.c b/drivers/mtd/spi-nor/controllers/aspeed-smc.c
index da49192a8220..328b008fafb2 100644
--- a/drivers/mtd/spi-nor/controllers/aspeed-smc.c
+++ b/drivers/mtd/spi-nor/controllers/aspeed-smc.c
@@ -826,10 +826,14 @@ static int aspeed_smc_setup_flash(struct aspeed_smc_controller *controller,
unsigned int cs;
int ret = -ENODEV;
- for_each_available_child_of_node(np, child) {
+ for_each_child_of_node(np, child) {
struct aspeed_smc_chip *chip;
struct spi_nor *nor;
+ /* Skip disabled nodes, but include reserved ones for later attachment */
+ if (!of_device_is_available(child) && !of_device_is_reserved(child))
+ continue;
+
/* This driver does not support NAND or NOR flash devices. */
if (!of_device_is_compatible(child, "jedec,spi-nor"))
continue;
@@ -873,6 +877,9 @@ static int aspeed_smc_setup_flash(struct aspeed_smc_controller *controller,
controller->chips[cs] = chip;
+ if (of_device_is_reserved(child))
+ continue;
+
ret = aspeed_smc_register_chip(chip);
if (ret)
break;
--
2.33.0
next prev parent reply other threads:[~2021-09-29 11:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 11:54 [PATCH 0/6] Dynamic aspeed-smc flash chips via "reserved" DT status Zev Weiss
2021-09-29 11:54 ` [PATCH 1/6] of: base: Add function to check for status = "reserved" Zev Weiss
2021-09-29 15:49 ` Rob Herring
2021-09-29 11:54 ` [PATCH 2/6] mtd: core: clear out unregistered devices a bit more Zev Weiss
2021-09-29 11:54 ` [PATCH 3/6] mtd: spi-nor: aspeed: Refactor registration/unregistration Zev Weiss
2021-10-06 0:03 ` Dhananjay Phadke
2021-09-29 11:54 ` [PATCH 4/6] mtd: spi-nor: aspeed: Allow attaching & detaching chips at runtime Zev Weiss
2021-09-29 11:54 ` Zev Weiss [this message]
2021-09-29 11:54 ` [PATCH 6/6] ARM: dts: aspeed: Add e3c246d4i BIOS flash device Zev Weiss
2021-09-29 16:08 ` [PATCH 0/6] Dynamic aspeed-smc flash chips via "reserved" DT status Rob Herring
2021-09-29 22:00 ` Zev Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210929115409.21254-6-zev@bewilderbeest.net \
--to=zev@bewilderbeest.net \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=gregkh@linuxfoundation.org \
--cc=jk@codeconstruct.com.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=openbmc@lists.ozlabs.org \
--cc=p.yadav@ti.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).