From: Adriana Kobylak <anoo@linux.ibm.com>
To: Joel Stanley <joel@jms.id.au>
Cc: Andrew Jeffery <andrew@aj.id.au>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Adriana Kobylak <anoo@us.ibm.com>
Subject: Re: [PATCH u-boot v2019.04-aspeed-openbmc] aspeed/hace: Reset when error occurs
Date: Fri, 16 Jul 2021 09:54:41 -0500 [thread overview]
Message-ID: <20A7316B-7A1B-41B3-B5D4-EF9CEA98F279@linux.ibm.com> (raw)
In-Reply-To: <20210715045258.13912-1-joel@jms.id.au>
> On Jul 14, 2021, at 11:52 PM, Joel Stanley <joel@jms.id.au> wrote:
>
> Some hasing operations have been triggering an error state.
>
> This can be reproduced on the u-boot command line:
>
> hash sha512 83000128 3762a8
>
> This completes, and the hash is correct. However HACE1C, the status
> register, shows an error bit is set 0x00800000.
>
> $ bitfield HACE1C 0x00800000 |grep 0x1
> Hash input data buffer overflow: 0x1
>
> The next operation is queued, and this never completes. The status
> register shows 0x00c00001
>
> $ bitfield HACE1C 0x00c00001 |grep 0x1
> Hash input data buffer overflow: 0x1
> Hash input rorate data overflow: 0x1
> Hash engine busy: 0x1
>
> A HACE reset will clear this state:
>
> mw.l 0x1e6e2040 0x10
> mw.l 0x1e6e2044 0x10
>
> Adding code to do this if any error bits are set in the status register
> is a workaround for the issue while further debugging is done.
>
> Another workaround is to do an operation before running the problematic
> operation. This sequence succeeds:
>
> hash sha512 83000000 10
> hash sha512 83000128 3762a8
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
Tested-by: Adriana Kobylak <anoo@us.ibm.com>
> ---
> drivers/crypto/aspeed_hace.c | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/crypto/aspeed_hace.c b/drivers/crypto/aspeed_hace.c
> index a99fb7c249be..f40779c08816 100644
> --- a/drivers/crypto/aspeed_hace.c
> +++ b/drivers/crypto/aspeed_hace.c
> @@ -100,9 +100,18 @@ static int digest_object(const void *src, unsigned int length, void *digest,
> writel(HACE_SHA_BE_EN | method, base + ASPEED_HACE_HASH_CMD);
>
> /* SHA512 hashing appears to have a througput of about 12MB/s */
> - return aspeed_hace_wait_completion(base + ASPEED_HACE_STS,
> - HACE_HASH_ISR,
> - 1000 + (length >> 3));
> + aspeed_hace_wait_completion(base + ASPEED_HACE_STS, HACE_HASH_ISR,
> + 1000 + (length >> 3));
> +
> + if (readl(base + ASPEED_HACE_STS)) {
> + debug("\nHACE error 0x%08x, resetting\n", readl(base + 0x1c));
> +
> + writel(0x10, 0x1e6e2040);
> + mdelay(5);
> + writel(0x10, 0x1e6e2044);
> + }
> +
> + return 0;
> }
>
> void hw_sha1(const unsigned char *pbuf, unsigned int buf_len,
> --
> 2.32.0
>
prev parent reply other threads:[~2021-07-16 14:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 4:52 [PATCH u-boot v2019.04-aspeed-openbmc] aspeed/hace: Reset when error occurs Joel Stanley
2021-07-16 14:54 ` Adriana Kobylak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20A7316B-7A1B-41B3-B5D4-EF9CEA98F279@linux.ibm.com \
--to=anoo@linux.ibm.com \
--cc=andrew@aj.id.au \
--cc=anoo@us.ibm.com \
--cc=joel@jms.id.au \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).