From: Eddie James <eajames@linux.ibm.com>
To: Brandon Wyman <bjwyman@gmail.com>, Joel Stanley <joel@jms.id.au>,
openbmc@lists.ozlabs.org, Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] hwmon: (pmbus/ibm-cffps) max_power_out swap changes
Date: Wed, 29 Sep 2021 10:38:04 -0500 [thread overview]
Message-ID: <2a3e0a3c-c256-92e6-7b1f-e80d56ee5b2c@linux.ibm.com> (raw)
In-Reply-To: <20210928205051.1222815-1-bjwyman@gmail.com>
On 9/28/21 3:50 PM, Brandon Wyman wrote:
> The bytes for max_power_out from the ibm-cffps devices differ in byte
> order for some power supplies.
>
> The Witherspoon power supply returns the bytes in MSB/LSB order.
>
> The Rainier power supply returns the bytes in LSB/MSB order.
>
> The Witherspoon power supply uses version cffps1. The Rainier power
> supply should use version cffps2. If version is cffps1, swap the bytes
> before output to max_power_out.
Looks fine, thanks Brandon!
Reviewed-by: Eddie James <eajames@linux.ibm.com>
>
> Tested:
> Witherspoon before: 3148. Witherspoon after: 3148.
> Rainier before: 53255. Rainier after: 2000.
>
> Signed-off-by: Brandon Wyman <bjwyman@gmail.com>
> ---
> drivers/hwmon/pmbus/ibm-cffps.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwmon/pmbus/ibm-cffps.c b/drivers/hwmon/pmbus/ibm-cffps.c
> index df712ce4b164..79bfcd2749a6 100644
> --- a/drivers/hwmon/pmbus/ibm-cffps.c
> +++ b/drivers/hwmon/pmbus/ibm-cffps.c
> @@ -171,8 +171,14 @@ static ssize_t ibm_cffps_debugfs_read(struct file *file, char __user *buf,
> cmd = CFFPS_SN_CMD;
> break;
> case CFFPS_DEBUGFS_MAX_POWER_OUT:
> - rc = i2c_smbus_read_word_swapped(psu->client,
> - CFFPS_MAX_POWER_OUT_CMD);
> + if (cffps1 == psu->version) {
> + rc = i2c_smbus_read_word_swapped(psu->client,
> + CFFPS_MAX_POWER_OUT_CMD);
> + } else {
> + rc = i2c_smbus_read_word_data(psu->client,
> + CFFPS_MAX_POWER_OUT_CMD);
> + }
> +
> if (rc < 0)
> return rc;
>
next prev parent reply other threads:[~2021-09-29 15:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 20:50 [PATCH v2] hwmon: (pmbus/ibm-cffps) max_power_out swap changes Brandon Wyman
2021-09-29 15:38 ` Eddie James [this message]
2021-10-02 11:40 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a3e0a3c-c256-92e6-7b1f-e80d56ee5b2c@linux.ibm.com \
--to=eajames@linux.ibm.com \
--cc=bjwyman@gmail.com \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).