openbmc.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Matt Spinler <mspinler@linux.vnet.ibm.com>
To: openbmc@lists.ozlabs.org
Subject: Returning actual JSON booleans via REST (issue 3154)
Date: Thu, 28 Jun 2018 10:06:07 -0500	[thread overview]
Message-ID: <348f8850cb20c61f159a7d99a4d8b161@linux.vnet.ibm.com> (raw)

Hello,

I have some code up for review, 
https://gerrit.openbmc-project.xyz/#/c/11267, that
will fix the behavior of booleans being represented in the REST response 
JSON as a 1/0
instead of the proper JSON true/false.

While this does change behavior possibly after some systems have already 
deployed,
it was wrong before and I would propose it's better late to fix it than 
never.

But, I would like to know if anyone has any strong arguments for leaving 
it how it is?
Otherwise, I guess just be on the lookout for this commit going in if it 
affects your tools.

                 reply	other threads:[~2018-06-28 15:01 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=348f8850cb20c61f159a7d99a4d8b161@linux.vnet.ibm.com \
    --to=mspinler@linux.vnet.ibm.com \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).