From: Matt Spinler <mspinler@linux.ibm.com>
To: "Duke Du (杜祥嘉)" <Duke.Du@quantatw.com>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
Cc: "vernon.mauery@linux.intel.com" <vernon.mauery@linux.intel.com>,
"jason.m.bills@linux.intel.com" <jason.m.bills@linux.intel.com>,
"Fran Hsu (徐誌謙)" <Fran.Hsu@quantatw.com>,
"George Hung (洪忠敬)" <George.Hung@quantatw.com>
Subject: Re: Question of phosphor-sel-logger
Date: Wed, 24 Mar 2021 08:20:00 -0500 [thread overview]
Message-ID: <707efde2-b301-fc23-be4c-92d1d96d8432@linux.ibm.com> (raw)
In-Reply-To: <TY2PR04MB3712DCE11C578706F5F6401F88639@TY2PR04MB3712.apcprd04.prod.outlook.com>
On 3/24/2021 6:28 AM, Duke Du (杜祥嘉) wrote:
> Hi all,
>
> I used package phosphor-hwmon and phospor-sel-logger to monitor sensor and create log when sensor reading
> cross the threshold. I found after the commit 25b26e162bd109b51aa09b16f26f9aa3d9d940fa of phosphor-sel-logger
> would catch the signal "ThresholdAsserted" to create sensor threhold log in the journal, but the phosphor-hwmon
> would not send the signal "ThresholdAsserted" when sensor reading is abnormal so that phosphor-sel-logger
> would not create the sensor threhold log, am I right ?
>
> If I'm right, can you give me some suggestion to fix this side effect, or what setting I have lost in the
> phosphor-hwmon or phosphor-sel-logger ?
Hi,
That signal isn't defined in phosphor-dbus-interfaces, so phosphor-hwmon
cannot use it. When I tried to add it, it was rejected as-is with a
recommendation to break it up into separate signals for each alarm
property on each interface. At that point I gave up and had the code I
was working on at the time just look at propertiesChanged signals instead.
If you would like to take that up it would entail:
* Update
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-dbus-interfaces/+/39899
as requested
* Update phosphor-hwmon to emit the new signals
* Update phosphor-sel-logger to also listen for these new signals in
addition to the current one, or change the dbus-sensors code to only
emit the new signals.
> phosphor-sel-logger commit 25b26e162bd109b51aa09b16f26f9aa3d9d940fa link :
> https://github.com/openbmc/phosphor-sel-logger/commit/25b26e162bd109b51aa09b16f26f9aa3d9d940fa
>
> Thanks very much !
> Duke
next prev parent reply other threads:[~2021-03-24 13:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 11:28 Question of phosphor-sel-logger Duke Du (杜祥嘉)
2021-03-24 13:20 ` Matt Spinler [this message]
2021-03-24 16:07 ` rgrs
2021-03-25 8:22 ` Duke Du (杜祥嘉)
2021-03-25 14:25 ` Matt Spinler
2021-03-25 17:30 ` Bills, Jason M
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=707efde2-b301-fc23-be4c-92d1d96d8432@linux.ibm.com \
--to=mspinler@linux.ibm.com \
--cc=Duke.Du@quantatw.com \
--cc=Fran.Hsu@quantatw.com \
--cc=George.Hung@quantatw.com \
--cc=jason.m.bills@linux.intel.com \
--cc=openbmc@lists.ozlabs.org \
--cc=vernon.mauery@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).