From: Lei YU <mine260309@gmail.com>
To: Lei Yu <yulei.sh@bytedance.com>
Cc: Ed Tanous <edtanous@google.com>,
openbmc <openbmc@lists.ozlabs.org>,
Thang Nguyen <thang@amperemail.onmicrosoft.com>
Subject: Re: [External] Re: New test for patches in openbmc/openbmc
Date: Fri, 8 Oct 2021 16:32:00 +0800 [thread overview]
Message-ID: <CAARXrtnhAirRLo3EWM5=3KhjJWaWq1kPTeZ2=Yuec43Ebp1Y9g@mail.gmail.com> (raw)
In-Reply-To: <CAGm54UF82Xx_N0g2d0sOx8Yt0vZ--+eAk18cS_68nt2RPoL=pA@mail.gmail.com>
It's noticed that the `repotest` is enabled in CI and we got CI
failure due to node-manager's patch:
https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/47673
I know the right way is to ask Intel to upstream the node-manager and
fix the issues we met.
But in reality it's not easy and it takes time for Intel to upstream a
repo (and it depends on Intel to decide whether or not to upstream)
@Ed Do we really want to reject such patches?
On Tue, Sep 28, 2021 at 4:37 PM Lei Yu <yulei.sh@bytedance.com> wrote:
>
> > > I have a similar case.
> > > As an x86 system, some of the recipes/changes are referenced from
> > > Intel-BMC, which is not upstreamed.
> > > Currently, we had patches related to UART routing and
> > > phosphor-node-manager-proxy.
> > > The UART routing patches are being upstreamed thanks to Troy.
> > > The change to node-manager is related to the HW design difference, and
> > > due to the fact that phosphor-node-manager-proxy is in Intel-BMC, we
> > > can not really make the patch upstream.
> >
> > I'm not following why that's preventing upstreaming. If
> > node-manager-proxy is something you need on your systems, I don't see
> > a reason why we would avoid cleaning it up and upstreaming it, but I
> > have no details on what this patch is, or what it does, so it's really
> > hard to talk in concrete terms about how to proceed next.
>
> node-manager-proxy is in Intel-BMC, so we really need Intel to
> upstream it into openbmc.
>
> --
> BRs,
> Lei YU
next prev parent reply other threads:[~2021-10-08 8:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 22:35 New test for patches in openbmc/openbmc Ed Tanous
2021-09-22 9:02 ` Alexander Amelkin
2021-09-22 13:15 ` Verdun, Jean-Marie
2021-09-22 23:35 ` Oskar Senft
2021-09-23 2:49 ` John Broadbent
2021-09-23 17:09 ` Benjamin Fair
2021-09-23 23:57 ` Ed Tanous
2021-09-23 23:38 ` Ed Tanous
2021-09-24 10:28 ` Thang Nguyen
2021-09-24 11:06 ` [External] " Lei Yu
2021-09-27 16:33 ` Ed Tanous
2021-09-28 8:36 ` Lei Yu
2021-10-08 8:32 ` Lei YU [this message]
2021-10-08 17:35 ` Ed Tanous
2021-10-09 2:18 ` Lei Yu
2021-10-11 17:47 ` Ed Tanous
2021-09-27 16:39 ` Ed Tanous
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAARXrtnhAirRLo3EWM5=3KhjJWaWq1kPTeZ2=Yuec43Ebp1Y9g@mail.gmail.com' \
--to=mine260309@gmail.com \
--cc=edtanous@google.com \
--cc=openbmc@lists.ozlabs.org \
--cc=thang@amperemail.onmicrosoft.com \
--cc=yulei.sh@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).