openbmc.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Joel Stanley <joel@jms.id.au>
To: Eddie James <eajames@linux.ibm.com>
Cc: OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH U-Boot v2019.04-aspeed-openbmc 3/3] configs: Add AST2600 SPL eMMC configuration
Date: Wed, 28 Oct 2020 04:29:09 +0000	[thread overview]
Message-ID: <CACPK8Xe4ThBz_b-Bs_VkChU0kofO+f7nAJXoZOfdnvFw2geBpw@mail.gmail.com> (raw)
In-Reply-To: <348a64cf-91a2-8852-d2c4-3f4a37d5569b@linux.ibm.com>

On Mon, 12 Oct 2020 at 13:36, Eddie James <eajames@linux.ibm.com> wrote:
>
>
> On 10/8/20 10:44 PM, Joel Stanley wrote:
> > On Mon, 28 Sep 2020 at 20:28, Eddie James <eajames@linux.ibm.com> wrote:
> >
> >> diff --git a/include/configs/aspeed-common.h b/include/configs/aspeed-common.h
> >> index 4c83035d3c..876958735b 100755
> >> --- a/include/configs/aspeed-common.h
> >> +++ b/include/configs/aspeed-common.h
> >> @@ -41,6 +41,12 @@
> >>   #define CONFIG_SYS_BOOTMAPSZ           (256 * 1024 * 1024)
> >>   #define CONFIG_SYS_MALLOC_LEN          (32 << 20)
> >>
> >> +#ifdef CONFIG_ENV_IS_IN_MMC
> >> +#define CONFIG_SYS_MMC_ENV_DEV         0
> >> +#define CONFIG_SYS_MMC_ENV_PART                0
> >> +#define CONFIG_ENV_OFFSET_REDUND       0x15000
> > 84KB? How was this chosen?
>
>
> The env is at 0x5000 in the user partition, and is sized at 0x10000. The
> redundant follows it immediately...

Can you put that and the information from your other email in the
commit message.

  reply	other threads:[~2020-10-28  4:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-28 20:27 [PATCH U-Boot v2019.04-aspeed-openbmc 0/3] Aspeed: Support eMMC boot Eddie James
2020-09-28 20:27 ` [PATCH U-Boot v2019.04-aspeed-openbmc 1/3] ARM: dts: Aspeed: Tacoma and Rainier: Add eMMC nodes and parameters Eddie James
2020-10-09  3:40   ` Joel Stanley
2020-09-28 20:27 ` [PATCH U-Boot v2019.04-aspeed-openbmc 2/3] arch: ARM: Aspeed: Add SPL eMMC partition boot support Eddie James
2020-10-09  3:41   ` Joel Stanley
2020-10-12 13:34     ` Eddie James
2020-10-28  4:28       ` Joel Stanley
2020-09-28 20:27 ` [PATCH U-Boot v2019.04-aspeed-openbmc 3/3] configs: Add AST2600 SPL eMMC configuration Eddie James
2020-10-09  3:44   ` Joel Stanley
2020-10-12 13:36     ` Eddie James
2020-10-28  4:29       ` Joel Stanley [this message]
2020-10-09  3:50   ` Joel Stanley
2020-10-12 13:41     ` Eddie James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACPK8Xe4ThBz_b-Bs_VkChU0kofO+f7nAJXoZOfdnvFw2geBpw@mail.gmail.com \
    --to=joel@jms.id.au \
    --cc=eajames@linux.ibm.com \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).