openbmc.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Joel Stanley <joel@jms.id.au>
To: John Wang <wangzhiqiang.bj@bytedance.com>
Cc: "OpenBMC Maillist" <openbmc@lists.ozlabs.org>,
	郁雷 <yulei.sh@bytedance.com>,
	xuxiaohan@bytedance.com
Subject: Re: [PATCH linux dev-5.8 v3 2/2] ARM: dts: aspeed: Add Bytedance g220a BMC machine
Date: Wed, 7 Oct 2020 06:53:27 +0000	[thread overview]
Message-ID: <CACPK8XeFfBQKnWnn-4Jmr9VMV0CxpERNsfPeHOVT610457pnvg@mail.gmail.com> (raw)
In-Reply-To: <CACPK8XdVSRQU92+hqYyVRe2QTgnKSFgn2QVf7P4VX4jyKvyYFw@mail.gmail.com>

On Wed, 7 Oct 2020 at 06:38, Joel Stanley <joel@jms.id.au> wrote:
>
> On Tue, 29 Sep 2020 at 06:40, John Wang <wangzhiqiang.bj@bytedance.com> wrote:
> >
> > From: Lotus Xu <xuxiaohan@bytedance.com>
> >
> > The g220a is a server platform with an ASPEED AST2500 BMC.
> >
> > Signed-off-by: Lotus Xu <xuxiaohan@bytedance.com>
> > Signed-off-by: John Wang <wangzhiqiang.bj@bytedance.com>
>
> Reviewed-by: Joel Stanley <joel@jms.id.au>
>
> Thanks, I've applied this to dev-5.8.
>


> +&kcs3 {
> +       kcs_addr = <0xCA2>;
> +       status = "okay";
> +};
> +
> +&kcs4 {
> +       kcs_addr = <0xCA4>;
> +       status = "okay";
> +};

I booted your system in qemu and noticed the kcs driver failed to load:

[    2.717595] ast-kcs-bmc: probe of 1e78902c.kcs failed with error -22
[    2.719104] ast-kcs-bmc: probe of 1e789114.kcs failed with error -22

You need to adjust your system to the v2 bindings, in the same way
this patch did:

https://patchwork.ozlabs.org/project/openbmc/patch/20200930075153.2115-1-aladyshev22@gmail.com/

As I have already merged your patch, I did this for you.

# ls /dev/ipmi-kcs*
/dev/ipmi-kcs3  /dev/ipmi-kcs4

Cheers,

Joel

      reply	other threads:[~2020-10-07  6:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-29  6:39 [PATCH linux dev-5.8 v3 1/2] ARM: dts: Add 64MiB OpenBMC flash layout John Wang
2020-09-29  6:39 ` [PATCH linux dev-5.8 v3 2/2] ARM: dts: aspeed: Add Bytedance g220a BMC machine John Wang
2020-10-07  6:38   ` Joel Stanley
2020-10-07  6:53     ` Joel Stanley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACPK8XeFfBQKnWnn-4Jmr9VMV0CxpERNsfPeHOVT610457pnvg@mail.gmail.com \
    --to=joel@jms.id.au \
    --cc=openbmc@lists.ozlabs.org \
    --cc=wangzhiqiang.bj@bytedance.com \
    --cc=xuxiaohan@bytedance.com \
    --cc=yulei.sh@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).