From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Zev Weiss <zev@bewilderbeest.net>
Cc: devicetree@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Jeremy Kerr" <jk@codeconstruct.com.au>,
"Heiner Kallweit" <hkallweit1@gmail.com>
Subject: Re: [PATCH 1/9] sysfs: add sysfs_remove_bin_file_self() function
Date: Thu, 7 Oct 2021 08:12:37 +0200 [thread overview]
Message-ID: <YV6P1dM6U6sSsefc@kroah.com> (raw)
In-Reply-To: <YV6Moz5eCsf6ZZWb@hatter.bewilderbeest.net>
On Wed, Oct 06, 2021 at 10:58:59PM -0700, Zev Weiss wrote:
> On Wed, Oct 06, 2021 at 10:23:33PM PDT, Greg Kroah-Hartman wrote:
> > On Wed, Oct 06, 2021 at 05:09:46PM -0700, Zev Weiss wrote:
> > > This is simply the bin_attribute analog to sysfs_remove_file_self().
> >
> > No, no binary sysfs file should be triggering a remove.
> >
> > binary sysfs files are "pass-through-only" from userspace to hardware,
> > the kernel should not be even knowing what is read/written to them.
> >
> > What do you think this is needed for?
> >
>
> So, I initially set out to be able to activate/deactivate specific DT nodes
> at runtime by using the device-tree "reserved" status as defined in the spec
> (but not currently used anywhere in the kernel) to mean essentially "create
> a device for this but don't bind a driver to it" (leaving it to userspace to
> invoke bind/unbind or similar), and added initial support for the specific
> driver I'm concerned with at the moment (aspeed-smc) -- that was the
> previous patch series linked in the cover letter of this one.
>
> In the discussion of that series, Rob suggested as an alternate approach:
>
> > Another possibility is making 'status' writeable from userspace. It is
> > just a sysfs file.
>
> That seemed sort of appealing to me, and this seemed like the most obvious
> way to go about implementing it. Given that DT properties are binary
> attributes, I gather you'd consider that a non-starter though?
Why would a text attribute of "status" be a binary sysfs file? That
feels really wrong as again, binary sysfs files are not supposed to be
parsed or handled by the kernel at all, they are only a pass-through.
thanks,
greg k-h
next prev parent reply other threads:[~2021-10-07 6:13 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 0:09 [PATCH 0/9] Dynamic DT device nodes Zev Weiss
2021-10-07 0:09 ` [PATCH 1/9] sysfs: add sysfs_remove_bin_file_self() function Zev Weiss
2021-10-07 5:23 ` Greg Kroah-Hartman
2021-10-07 5:58 ` Zev Weiss
2021-10-07 6:12 ` Greg Kroah-Hartman [this message]
2021-10-07 6:55 ` Zev Weiss
2021-10-07 0:09 ` [PATCH 2/9] sysfs: add growable flag to struct bin_attribute Zev Weiss
2021-10-07 0:09 ` [PATCH 3/9] lib/string: add sysfs_buf_streq() Zev Weiss
2021-10-07 0:09 ` [PATCH 4/9] of: add self parameter to __of_sysfs_remove_bin_file() Zev Weiss
2021-10-07 5:25 ` Greg Kroah-Hartman
2021-10-07 0:09 ` [PATCH 5/9] of: add self parameter to of_update_property() Zev Weiss
2021-10-07 5:26 ` Greg Kroah-Hartman
2021-10-07 0:09 ` [PATCH 6/9] of: add support for 'dynamic' DT property Zev Weiss
2021-10-08 18:51 ` Frank Rowand
2021-10-08 19:19 ` Frank Rowand
2021-10-11 13:58 ` Frank Rowand
2021-10-11 14:46 ` Frank Rowand
2021-10-11 17:35 ` Zev Weiss
2021-10-07 0:09 ` [PATCH 7/9] of: make OF_DYNAMIC selectable independently of OF_UNITTEST Zev Weiss
2021-10-08 19:01 ` Frank Rowand
2021-10-07 0:09 ` [PATCH 8/9] dt-bindings: document new 'dynamic' common property Zev Weiss
2021-10-07 5:26 ` Greg Kroah-Hartman
2021-10-07 6:03 ` Zev Weiss
2021-10-07 0:09 ` [PATCH 9/9] ARM: dts: aspeed: Add e3c246d4i BIOS flash device Zev Weiss
2021-10-07 2:46 ` [PATCH 0/9] Dynamic DT device nodes Florian Fainelli
2021-10-07 5:44 ` Zev Weiss
2021-10-07 7:04 ` Andy Shevchenko
2021-10-07 9:05 ` Zev Weiss
2021-10-07 10:31 ` Greg Kroah-Hartman
2021-10-07 15:41 ` Zev Weiss
2021-10-07 20:03 ` Rob Herring
2021-10-08 5:41 ` Greg Kroah-Hartman
2021-10-08 19:43 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YV6P1dM6U6sSsefc@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bhelgaas@google.com \
--cc=daniel.vetter@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=jk@codeconstruct.com.au \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).