From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Eddie James" <eajames@linux.ibm.com>, openbmc@lists.ozlabs.org
Subject: Re: [PATCH linux dev-5.8 v3] ARM: dts: Aspeed: Rainier: Add 4U device-tree
Date: Fri, 30 Oct 2020 14:39:42 +1030 [thread overview]
Message-ID: <b3a92e61-ffe2-48d6-a4b5-487b22b3bdd6@www.fastmail.com> (raw)
In-Reply-To: <20201028185647.14565-1-eajames@linux.ibm.com>
On Thu, 29 Oct 2020, at 05:26, Eddie James wrote:
> Add a device-tree for the Rainier 4U system. Change the model name
> on the existing Rainier device-tree to 2U, and remove the two
> extra power supplies that are only present on the 4U system. Also
> add labels to the fan nodes for use in the 4U device-tree.
>
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> ---
> Changes since v2:
> - Just reference individual fan nodes rather than the whole fan
> controller
>
> Changes since v1:
> - Don't rename the 2U dts
> - Include the 2U dts from the 4U and make the necessary Changes
>
> arch/arm/boot/dts/Makefile | 1 +
> .../boot/dts/aspeed-bmc-ibm-rainier-4u.dts | 37 +++++++++++++++++++
> arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 20 +++-------
> 3 files changed, 43 insertions(+), 15 deletions(-)
> create mode 100644 arch/arm/boot/dts/aspeed-bmc-ibm-rainier-4u.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 7e4d3600e16d..9a2ab5e6e924 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1360,6 +1360,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
> aspeed-bmc-facebook-yamp.dtb \
> aspeed-bmc-facebook-yosemitev2.dtb \
> aspeed-bmc-ibm-rainier.dtb \
> + aspeed-bmc-ibm-rainier-4u.dtb \
> aspeed-bmc-intel-s2600wf.dtb \
> aspeed-bmc-inspur-fp5280g2.dtb \
> aspeed-bmc-lenovo-hr630.dtb \
> diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier-4u.dts
> b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier-4u.dts
> new file mode 100644
> index 000000000000..9c35ac1d19a6
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier-4u.dts
> @@ -0,0 +1,37 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +// Copyright 2020 IBM Corp.
> +/dts-v1/;
> +
> +#include "aspeed-bmc-ibm-rainier-4u.dts"
> +
> +/ {
> + model = "Rainier 4U";
> +};
> +
> +&i2c3 {
> + power-supply@6a {
> + compatible = "ibm,cffps";
> + reg = <0x6a>;
> + };
> +
> + power-supply@6b {
> + compatible = "ibm,cffps";
> + reg = <0x6b>;
> + };
> +};
> +
> +&fan0 {
> + tach-pulses = <4>;
> +};
> +
> +&fan1 {
> + tach-pulses = <4>;
> +};
> +
> +&fan2 {
> + tach-pulses = <4>;
> +};
> +
> +&fan3 {
> + tach-pulses = <4>;
I'm still digging for info on the tac-pulses, but we can fix them later if necessary.
Looks okay otherwise:
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
next prev parent reply other threads:[~2020-10-30 4:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 18:56 [PATCH linux dev-5.8 v3] ARM: dts: Aspeed: Rainier: Add 4U device-tree Eddie James
2020-10-30 4:09 ` Andrew Jeffery [this message]
2020-10-30 4:14 ` Joel Stanley
2020-10-30 13:51 ` Eddie James
2020-11-01 23:14 ` Joel Stanley
2020-11-02 14:48 ` Eddie James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3a92e61-ffe2-48d6-a4b5-487b22b3bdd6@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=eajames@linux.ibm.com \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).