From: Jeremy Kerr <jk@ozlabs.org>
To: Eddie James <eajames@linux.ibm.com>, linux-kernel@vger.kernel.org
Cc: linux-hwmon@vger.kernel.org, jdelvare@suse.com,
openbmc@lists.ozlabs.org, linux@roeck-us.net,
linux-fsi@lists.ozlabs.org
Subject: Re: [PATCH 3/3] fsi: occ: Add dynamic debug to dump command and response
Date: Thu, 22 Jul 2021 07:28:27 +0800 [thread overview]
Message-ID: <de6a55a881eae463014af0fe165b60a378773d1d.camel@ozlabs.org> (raw)
In-Reply-To: <20210716151850.28973-4-eajames@linux.ibm.com>
Hi Eddie,
> Use the dynamic branching capability of the dynamic debug subsystem
> to dump the command and response with the correct OCC device name.
Would this be better done with a tracepoint? Given it's a fairly
well-defined pair of events, and there's data to dump in both cases.
We have a couple of existing tracepoionts in the core code if that
helps...
Cheers,
Jeremy
prev parent reply other threads:[~2021-07-21 23:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-16 15:18 [PATCH 0/3] OCC: fsi and hwmon: Set sequence number in submit interface Eddie James
2021-07-16 15:18 ` [PATCH 1/3] fsi: occ: Force sequence numbering per OCC Eddie James
2021-07-21 2:37 ` Joel Stanley
2021-07-21 13:27 ` Eddie James
2021-07-16 15:18 ` [PATCH 2/3] hwmon: (occ) Remove sequence numbering and checksum calculation Eddie James
2021-07-17 14:04 ` Guenter Roeck
2021-07-18 20:08 ` kernel test robot
2021-07-18 20:26 ` kernel test robot
2021-07-21 2:43 ` Joel Stanley
2021-07-21 13:41 ` Eddie James
2021-07-16 15:18 ` [PATCH 3/3] fsi: occ: Add dynamic debug to dump command and response Eddie James
2021-07-19 0:26 ` kernel test robot
2021-07-21 23:28 ` Jeremy Kerr [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de6a55a881eae463014af0fe165b60a378773d1d.camel@ozlabs.org \
--to=jk@ozlabs.org \
--cc=eajames@linux.ibm.com \
--cc=jdelvare@suse.com \
--cc=linux-fsi@lists.ozlabs.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).