openembedded-devel.lists.openembedded.org archive mirror
 help / color / mirror / Atom feed
From: Armin Kuster <akuster808@gmail.com>
To: openembedded-devel@lists.openembedded.org
Cc: Khem Raj <raj.khem@gmail.com>
Subject: [meta-oe][mickledore][PATCH 21/36] libnice: Remove buildpaths from binaries
Date: Wed, 31 May 2023 07:12:54 -0400	[thread overview]
Message-ID: <20230531111309.2454603-21-akuster808@gmail.com> (raw)
In-Reply-To: <20230531111309.2454603-1-akuster808@gmail.com>

From: Khem Raj <raj.khem@gmail.com>

Fixes
WARNING: libnice-0.1.21-r0 do_package_qa: QA Issue: File /usr/src/debug/libnice/0.1.21-r0/agent/agent-enum-types.h in package libnice-src contains reference to TMPDIR [buildpaths]

Signed-off-by: Khem Raj <raj.khem@gmail.com>
(cherry picked from commit e34fa43eece60c60b0732ec7a2726ec6489794b9)
Signed-off-by: Armin Kuster <akuster808@gmail.com>
---
 ...meson-Replace-filename-with-basename.patch | 40 +++++++++++++++++++
 .../farsight/libnice_0.1.21.bb                |  3 +-
 2 files changed, 42 insertions(+), 1 deletion(-)
 create mode 100644 meta-oe/recipes-support/farsight/libnice/0001-agent-meson-Replace-filename-with-basename.patch

diff --git a/meta-oe/recipes-support/farsight/libnice/0001-agent-meson-Replace-filename-with-basename.patch b/meta-oe/recipes-support/farsight/libnice/0001-agent-meson-Replace-filename-with-basename.patch
new file mode 100644
index 0000000000..897de4a6ce
--- /dev/null
+++ b/meta-oe/recipes-support/farsight/libnice/0001-agent-meson-Replace-filename-with-basename.patch
@@ -0,0 +1,40 @@
+From 7c510cd20bb443064ab4a0d2c6d917e807b2671b Mon Sep 17 00:00:00 2001
+From: Khem Raj <raj.khem@gmail.com>
+Date: Mon, 22 May 2023 19:45:28 -0700
+Subject: [PATCH] agent/meson: Replace filename with basename
+
+This avoids emitting absolute paths into generated sourcecode, it
+improves reproducibility. See [1]
+
+[1] https://developer-old.gnome.org/gobject/stable/glib-mkenums.html
+
+Upstream-Status: Submitted [https://gitlab.freedesktop.org/libnice/libnice/-/merge_requests/258]
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+---
+ agent/meson.build | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/agent/meson.build b/agent/meson.build
+index 2e5b272..44fcd6b 100644
+--- a/agent/meson.build
++++ b/agent/meson.build
+@@ -29,14 +29,14 @@ gnome = import('gnome')
+ 
+ agent_enum_types_c =  gnome.mkenums('agent-enum-types.c', sources : agent_headers,
+ 				    fhead: '#include <config.h>\n#include <glib-object.h>\n#include "agent.h"\n#include "pseudotcp.h"\n#include "agent-enum-types.h"',
+-				    fprod: '\n/* enumerations from "@filename@" */',
++				    fprod: '\n/* enumerations from "@basename@" */',
+ 				    vhead: 'GType\n@enum_name@_get_type (void)\n{\n  static GType type = 0;\n  if (!type) {\n    static const G@Type@Value values[] = {',
+ 				    vprod: '      { @VALUENAME@, "@VALUENAME@", "@valuenick@" },',
+ 				    vtail: '      { 0, NULL, NULL }\n    };\n    type = g_@type@_register_static ("@EnumName@", values);\n  }\n  return type;\n}\n\n')
+ 
+ agent_enum_types_h = gnome.mkenums('agent-enum-types.h', sources : agent_headers,
+ 				   fhead: '#ifndef __AGENT_ENUM_TYPES_H__\n#define __AGENT_ENUM_TYPES_H__ 1\n\n#include <glib-object.h>\n\nG_BEGIN_DECLS\n',
+-				   fprod: '/* enumerations from "@filename@" */\n',
++				   fprod: '/* enumerations from "@basename@" */\n',
+ 				   vhead: 'GType @enum_name@_get_type (void) G_GNUC_CONST;\n#define NICE_TYPE_@ENUMSHORT@ (@enum_name@_get_type())\n',
+ 					  ftail: 'G_END_DECLS\n\n#endif /* !AGENT_ENUM_TYPES_H */')
+ 
+-- 
+2.40.1
+
diff --git a/meta-oe/recipes-support/farsight/libnice_0.1.21.bb b/meta-oe/recipes-support/farsight/libnice_0.1.21.bb
index 210d4d8228..f319b994bd 100644
--- a/meta-oe/recipes-support/farsight/libnice_0.1.21.bb
+++ b/meta-oe/recipes-support/farsight/libnice_0.1.21.bb
@@ -8,7 +8,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=9c42325015702feda4f4d2f19a55b767 \
                     file://COPYING.MPL;md5=3c617710e51cdbe0fc00716f056dfb1a \
 "
 
-SRC_URI = "http://nice.freedesktop.org/releases/libnice-${PV}.tar.gz"
+SRC_URI = "http://nice.freedesktop.org/releases/libnice-${PV}.tar.gz \
+           file://0001-agent-meson-Replace-filename-with-basename.patch"
 SRC_URI[sha256sum] = "72e73a2acf20f59093e21d5601606e405873503eb35f346fa621de23e99b3b39"
 
 DEPENDS = "glib-2.0 gnutls"
-- 
2.25.1



  parent reply	other threads:[~2023-05-31 11:13 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-31 11:12 [meta-oe][mickledore][PATCH 01/36] libencode-perl: Remove buildpaths from generated .exh files Armin Kuster
2023-05-31 11:12 ` [meta-oe][mickledore][PATCH 02/36] frr: add CVE_PRODUCT Armin Kuster
2023-05-31 11:12 ` [meta-oe][mickledore][PATCH 03/36] enca: Remove buildpaths from target scripts Armin Kuster
2023-05-31 11:12 ` [meta-oe][mickledore][PATCH 04/36] libirecovery: Add missing build dependency on readline Armin Kuster
2023-05-31 11:12 ` [meta-oe][mickledore][PATCH 05/36] fftw: Remove hardcoded sysroot into binaries Armin Kuster
2023-06-07  7:53   ` [oe] " Böszörményi Zoltán
2023-06-07  8:09     ` Khem Raj
2023-05-31 11:12 ` [meta-oe][mickledore][PATCH 06/36] lmdb: Pass CFLAGS to Makefile Armin Kuster
2023-05-31 11:12 ` [meta-oe][mickledore][PATCH 07/36] postgresql: upgrade 15.2 -> 15.3 Armin Kuster
2023-05-31 11:12 ` [meta-oe][mickledore][PATCH 08/36] ipmitool: Update links Armin Kuster
2023-05-31 11:12 ` [meta-oe][mickledore][PATCH 09/36] minicoredumper: correct the sysvinit service file attribute Armin Kuster
2023-05-31 11:12 ` [meta-oe][mickledore][PATCH 10/36] php: upgrade 8.2.5 -> 8.2.6 Armin Kuster
2023-05-31 11:12 ` [meta-oe][mickledore][PATCH 11/36] php: Remove buildpaths from scripts and generated headers Armin Kuster
2023-05-31 11:12 ` [meta-oe][mickledore][PATCH 12/36] libusbgx: drop hard-coded /usr/bin,/etc Armin Kuster
2023-05-31 11:12 ` [meta-oe][mickledore][PATCH 13/36] libusbgx: check scripts in /etc/usbgx.d Armin Kuster
2023-05-31 11:12 ` [meta-oe][mickledore][PATCH 14/36] uw-imap: Pass CFLAGS from environment Armin Kuster
2023-05-31 11:12 ` [meta-oe][mickledore][PATCH 15/36] libmad: Add a patch to pass cflags to build Armin Kuster
2023-05-31 11:12 ` [meta-oe][mickledore][PATCH 16/36] libpeas: Fix reference to TMPDIR in tests Armin Kuster
2023-05-31 11:12 ` [meta-oe][mickledore][PATCH 17/36] lirc: Define SH_PATH=/bin/sh Armin Kuster
2023-05-31 11:12 ` [meta-oe][mickledore][PATCH 18/36] mce-inject: Pass CFLAGS to make Armin Kuster
2023-05-31 11:12 ` [meta-oe][mickledore][PATCH 19/36] nbdkit: Remove buildpaths from binaries Armin Kuster
2023-05-31 11:12 ` [meta-oe][mickledore][PATCH 20/36] mpv: Remove references to builddir from mpv binary Armin Kuster
2023-05-31 11:12 ` Armin Kuster [this message]
2023-05-31 11:12 ` [meta-oe][mickledore][PATCH 22/36] curlpp: Remove references to buildpaths e.g. TMPDIR Armin Kuster
2023-05-31 11:12 ` [meta-oe][mickledore][PATCH 23/36] unbound: Remove references to buildpaths Armin Kuster
2023-05-31 11:12 ` [meta-oe][mickledore][PATCH 24/36] uml-utilities: Fix references to TMPDIR Armin Kuster
2023-05-31 11:12 ` [meta-oe][mickledore][PATCH 25/36] openct: Fix buildpaths being emitted into generated types.h Armin Kuster
2023-05-31 11:12 ` [meta-oe][mickledore][PATCH 26/36] minifi-cpp: Remove references to buildpaths in generated files Armin Kuster
2023-05-31 11:13 ` [meta-oe][mickledore][PATCH 27/36] freerdp: Fix reference to TMPDIR in libfreerdp2.so Armin Kuster
2023-05-31 11:13 ` [meta-oe][mickledore][PATCH 28/36] nautilus: upgrade 44.0 -> 44.1 Armin Kuster
2023-05-31 11:13 ` [meta-oe][mickledore][PATCH 29/36] nautilus: Fix buildpath QA errors Armin Kuster
2023-05-31 11:13 ` [meta-oe][mickledore][PATCH 30/36] cgdb: Fix buildpaths emitted into cgdb binary Armin Kuster
2023-05-31 11:13 ` [meta-oe][mickledore][PATCH 31/36] ibus: Point python interpreter to target location Armin Kuster
2023-05-31 11:13 ` [meta-oe][mickledore][PATCH 32/36] gimp: Fix buildpaths in binaries and scripts Armin Kuster
2023-05-31 11:13 ` [meta-oe][mickledore][PATCH 33/36] libgphoto2: Edit out sysroot from CC variable in configure Armin Kuster
2023-05-31 11:13 ` [meta-oe][mickledore][PATCH 34/36] vlan: Pass CFLAGS via CCFLAGS Armin Kuster
2023-05-31 11:13 ` [meta-oe][mickledore][PATCH 35/36] sgpio: Pass CFLAGS to make Armin Kuster
2023-05-31 11:13 ` [meta-oe][mickledore][PATCH 36/36] x265: Pass --debug-prefix-map to nasm Armin Kuster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230531111309.2454603-21-akuster808@gmail.com \
    --to=akuster808@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).