From: Luca Weiss <luca@z3ntu.xyz>
To: linux-arm-msm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org,
"Matti Lehtimäki" <matti.lehtimaki@gmail.com>,
"Bjorn Andersson" <andersson@kernel.org>,
"Andy Gross" <agross@kernel.org>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Matti Lehtimäki" <matti.lehtimaki@gmail.com>
Subject: Re: [PATCH v2 1/2] pinctrl: qcom: msm8226: Add MPM pin mappings
Date: Sat, 23 Sep 2023 15:20:51 +0200 [thread overview]
Message-ID: <1866740.CQOukoFCf9@z3ntu.xyz> (raw)
In-Reply-To: <20230923131432.21721-2-matti.lehtimaki@gmail.com>
On Samstag, 23. September 2023 15:14:31 CEST Matti Lehtimäki wrote:
> Add pin <-> wakeirq mappings to allow for waking up the AP from sleep
> through MPM-connected pins.
>
> Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com>
Looks good now :)
Reviewed-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> Changes in v2:
> - Add missing entry to mapping
> ---
> drivers/pinctrl/qcom/pinctrl-msm8226.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm8226.c
> b/drivers/pinctrl/qcom/pinctrl-msm8226.c index 994619840a70..4030baa3715f
> 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm8226.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm8226.c
> @@ -612,6 +612,16 @@ static const struct msm_pingroup msm8226_groups[] = {
>
> #define NUM_GPIO_PINGROUPS 117
>
> +static const struct msm_gpio_wakeirq_map msm8226_mpm_map[] = {
> + { 1, 3 }, { 4, 4 }, { 5, 5 }, { 9, 6 }, { 13, 7 }, { 17, 8 },
> + { 21, 9 }, { 27, 10 }, { 29, 11 }, { 31, 12 }, { 33, 13 }, { 35, 14
},
> + { 37, 15 }, { 38, 16 }, { 39, 17 }, { 41, 18 }, { 46, 19 }, { 48, 20
},
> + { 49, 21 }, { 50, 22 }, { 51, 23 }, { 52, 24 }, { 54, 25 }, { 62, 26
},
> + { 63, 27 }, { 64, 28 }, { 65, 29 }, { 66, 30 }, { 67, 31 }, { 68, 32
},
> + { 69, 33 }, { 71, 34 }, { 72, 35 }, { 106, 36 }, { 107, 37 }, { 108,
38 },
> + { 109, 39 }, { 110, 40 }, { 111, 54 }, { 113, 55 }, { 115, 41 }, +};
> +
> static const struct msm_pinctrl_soc_data msm8226_pinctrl = {
> .pins = msm8226_pins,
> .npins = ARRAY_SIZE(msm8226_pins),
> @@ -620,6 +630,8 @@ static const struct msm_pinctrl_soc_data msm8226_pinctrl
> = { .groups = msm8226_groups,
> .ngroups = ARRAY_SIZE(msm8226_groups),
> .ngpios = NUM_GPIO_PINGROUPS,
> + .wakeirq_map = msm8226_mpm_map,
> + .nwakeirq_map = ARRAY_SIZE(msm8226_mpm_map),
> };
>
> static int msm8226_pinctrl_probe(struct platform_device *pdev)
next prev parent reply other threads:[~2023-09-23 13:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-23 13:14 [PATCH v2 0/2] MPM pin mappings for MSM8226 and MSM8974 Matti Lehtimäki
2023-09-23 13:14 ` [PATCH v2 1/2] pinctrl: qcom: msm8226: Add MPM pin mappings Matti Lehtimäki
2023-09-23 13:20 ` Luca Weiss [this message]
2023-09-27 8:44 ` Linus Walleij
2023-09-23 13:14 ` [PATCH v2 2/2] pinctrl: qcom: msm8974: " Matti Lehtimäki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1866740.CQOukoFCf9@z3ntu.xyz \
--to=luca@z3ntu.xyz \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.lehtimaki@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).