From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Cc: viresh.kumar@linaro.org, agross@kernel.org, rjw@rjwysocki.net,
devicetree@vger.kernel.org, robh+dt@kernel.org,
amit.kucheria@linaro.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org,
konrad.dybcio@somainline.org, marijn.suijten@somainline.org,
martin.botka@somainline.org, jeffrey.l.hugo@gmail.com
Subject: Re: [PATCH v4 5/7] cpufreq: qcom-hw: Implement CPRh aware OSM programming
Date: Mon, 19 Apr 2021 18:22:53 -0500 [thread overview]
Message-ID: <20210419232253.GW1538589@yoga> (raw)
In-Reply-To: <e486d752-b99a-3479-b2ae-b37cdb3edd9a@somainline.org>
On Mon 19 Apr 15:59 CDT 2021, AngeloGioacchino Del Regno wrote:
> Il 19/04/21 20:52, Bjorn Andersson ha scritto:
> > On Tue 19 Jan 11:45 CST 2021, AngeloGioacchino Del Regno wrote:
[..]
> > > +static int qcom_cpufreq_hw_acd_init(struct device *cpu_dev,
> > > + struct cpufreq_policy *policy,
> > > + int index)
> > > +{
[..]
> > > + acd_resname = kasprintf(GFP_KERNEL, "osm-acd%d", index);
> >
> > How about just sprintf() into a 10 byte array on the stack?
> >
>
> My motto, apart the clearly possible chance to get 1000 clusters in the
> future (lol), is to free the (very little) memory as soon as I'm done with
> it.
>
> Was I too much paranoid there again? :)))
>
Feel free to waste a couple of extra bytes in that array then ;)
[..]
> > > static int qcom_cpufreq_hw_driver_probe(struct platform_device *pdev)
[..]
> > > + /*
> > > + * If the power domain device is not registered yet, then
> > > + * defer probing this driver until that is available.
> > > + */
> > > + pd_dev = of_find_device_by_node(pd_node);
> > > + if (!pd_dev || !pd_dev->dev.driver ||
> > > + !device_is_bound(&pd_dev->dev))
> > > + return -EPROBE_DEFER;
> >
> > I wonder if there's a more appropriate way to probe defer on resources
> > described in the CPU nodes...
> >
>
> I was wondering the same. I had nightmares about this one.
> If there's any better way... please, let me know!
>
Let's see if Viresh has any good suggestions, otherwise let's stick with
this for now.
>
> P.S.: There is a v5 of this (and CPR3) set(s) that I had sent immediately
> after this v4, back in January, addressing the big abuse of the OPP API that
> is present in the v4 (this) version of the driver.
>
May I ask for you to incorporate the changes I pointed out here and post
a v6 instead of me re-reviewing v5? I'll make sure to prioritize the
next round.
Thanks,
Bjorn
next prev parent reply other threads:[~2021-04-19 23:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 17:45 [PATCH v4 0/7] cpufreq-qcom-hw: Implement full OSM programming AngeloGioacchino Del Regno
2021-01-19 17:45 ` [PATCH v4 1/7] cpufreq: blacklist SDM630/636/660 in cpufreq-dt-platdev AngeloGioacchino Del Regno
2021-04-19 19:18 ` Bjorn Andersson
2021-01-19 17:45 ` [PATCH v4 2/7] cpufreq: blacklist MSM8998 " AngeloGioacchino Del Regno
2021-04-19 19:18 ` Bjorn Andersson
2021-01-19 17:45 ` [PATCH v4 3/7] dt-bindings: arm: cpus: Document 'qcom,freq-domain' property AngeloGioacchino Del Regno
2021-01-19 17:45 ` [PATCH v4 4/7] dt-bindings: cpufreq: cpufreq-qcom-hw: Convert to YAML bindings AngeloGioacchino Del Regno
2021-04-19 19:17 ` Bjorn Andersson
2021-01-19 17:45 ` [PATCH v4 5/7] cpufreq: qcom-hw: Implement CPRh aware OSM programming AngeloGioacchino Del Regno
2021-01-20 18:25 ` Taniya Das
2021-01-20 18:54 ` AngeloGioacchino Del Regno
2021-01-20 19:05 ` Bjorn Andersson
2021-02-10 5:13 ` Viresh Kumar
2021-04-12 9:31 ` Taniya Das
2021-04-13 3:49 ` Viresh Kumar
2021-04-15 1:31 ` Taniya Das
2021-04-19 19:06 ` Bjorn Andersson
2021-04-19 18:52 ` Bjorn Andersson
2021-04-19 20:59 ` AngeloGioacchino Del Regno
2021-04-19 23:22 ` Bjorn Andersson [this message]
2021-04-20 3:37 ` Viresh Kumar
2021-01-19 17:45 ` [PATCH v4 6/7] cpufreq: qcom-hw: Allow getting the maximum transition latency for OPPs AngeloGioacchino Del Regno
2021-04-19 19:19 ` Bjorn Andersson
2021-01-19 17:45 ` [PATCH v4 7/7] dt-bindings: cpufreq: qcom-hw: Add bindings for 8998 AngeloGioacchino Del Regno
2021-04-12 5:11 ` [PATCH v4 0/7] cpufreq-qcom-hw: Implement full OSM programming Viresh Kumar
2021-04-13 2:41 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210419232253.GW1538589@yoga \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=amit.kucheria@linaro.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=devicetree@vger.kernel.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=konrad.dybcio@somainline.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=phone-devel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).