From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Luca Weiss <luca@z3ntu.xyz>, Brian Masney <bmasney@redhat.com>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Brian Masney <masneyb@onstation.org>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 3/4] Input: pwm-vibra - add support for enable GPIO
Date: Tue, 2 May 2023 12:39:10 +0200 [thread overview]
Message-ID: <8a54d0ec-8a22-9ffd-43a4-55da988fbeb1@linaro.org> (raw)
In-Reply-To: <8250064.NyiUUSuA9g@z3ntu.xyz>
On 28.04.2023 18:06, Luca Weiss wrote:
> On Freitag, 28. April 2023 01:29:27 CEST Brian Masney wrote:
>> On Thu, Apr 27, 2023 at 10:34:28PM +0200, Luca Weiss wrote:
>>> Some pwm vibrators have a dedicated enable GPIO that needs to be set
>>> high so that the vibrator works. Add support for that optionally.
>>>
>>> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
>>
>> Hi Luca,
>>
>> Thank you for picking up this work!
>>
>>> + vibrator->enable_gpio = devm_gpiod_get_optional(&pdev->dev,
> "enable",
>>> +
> GPIOD_OUT_LOW);
>>> + err = PTR_ERR_OR_ZERO(vibrator->enable_gpio);
>>> + if (err) {
>>> + if (err != -EPROBE_DEFER)
>>> + dev_err(&pdev->dev, "Failed to request enable
> gpio: %d\n",
>>> + err);
>>> + return err;
>>> + }
>>> +
>>
Looks like your email client messes with the replies.. perhaps it tries
to round them to n characters forcefully?
Konrad
>> Take a look at dev_err_probe() to remove the -EPROBE_DEFER check.
>
> The input subsystem doesn't like dev_err_probe for some reason, you should
> quickly find examples of that being rejected on the mailing list (or see
> "git grep dev_err_probe drivers/input/")
>
>>
>> With that fixed:
>>
>> Reviewed-by: Brian Masney <bmasney@redhat.com>
>
> Thanks for the reviews!
>
>
next prev parent reply other threads:[~2023-05-02 10:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 20:34 [PATCH 0/4] Add haptics support to Nexus 5 using pwm-vibra driver Luca Weiss
2023-04-27 20:34 ` [PATCH 1/4] dt-bindings: input: pwm-vibrator: Add enable-gpio Luca Weiss
2023-04-27 23:29 ` Brian Masney
2023-04-28 10:10 ` Caleb Connolly
2023-04-29 19:44 ` Sebastian Reichel
2023-05-01 6:48 ` Krzysztof Kozlowski
2023-04-27 20:34 ` [PATCH 2/4] Input: pwm-vibra - add newline to dev_err prints Luca Weiss
2023-04-27 23:30 ` Brian Masney
2023-04-28 10:10 ` Caleb Connolly
2023-04-29 19:45 ` Sebastian Reichel
2023-04-27 20:34 ` [PATCH 3/4] Input: pwm-vibra - add support for enable GPIO Luca Weiss
2023-04-27 23:29 ` Brian Masney
2023-04-28 16:06 ` Luca Weiss
2023-04-28 16:11 ` Brian Masney
2023-05-02 10:39 ` Konrad Dybcio [this message]
2023-05-02 15:24 ` Luca Weiss
2023-04-28 10:11 ` Caleb Connolly
2023-04-29 19:47 ` Sebastian Reichel
2023-05-02 0:47 ` Dmitry Torokhov
2023-05-02 15:35 ` Luca Weiss
2023-04-27 20:34 ` [PATCH 4/4] ARM: dts: qcom: msm8974-hammerhead: Add vibrator Luca Weiss
2023-04-27 23:34 ` Brian Masney
2023-04-28 10:11 ` Caleb Connolly
2023-05-02 10:40 ` Konrad Dybcio
2023-05-02 15:28 ` Luca Weiss
2023-05-02 15:31 ` Konrad Dybcio
2023-05-08 16:44 ` [PATCH 0/4] Add haptics support to Nexus 5 using pwm-vibra driver Dmitry Torokhov
2023-05-25 4:54 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a54d0ec-8a22-9ffd-43a4-55da988fbeb1@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bmasney@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=masneyb@onstation.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).