From: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Amit Pundir <amit.pundir@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
John Stultz <john.stultz@linaro.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
dt <devicetree@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
phone-devel@vger.kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add DSI and panel bits
Date: Mon, 8 Feb 2021 15:41:23 +0100 [thread overview]
Message-ID: <9bbeb403-2937-aebd-91ff-5682f9112dee@somainline.org> (raw)
In-Reply-To: <CAMi1Hd3bgDaqsH+txFVEnBc9dsGbrgic5TK7uq4GwqqkM6seiw@mail.gmail.com>
>>> + ports {
>>> + port@1 {
>>> + endpoint {
>>> + remote-endpoint = <&tianma_nt36672a_in_0>;
>>> + data-lanes = <0 1 2 3>;
>>> + };
>>> + };
>>> + };
>> The endpoint has a label, you can simply use &dsi0_out {};.
> I didn't get what you meant there. Care to point to some reference dts
> snippet please?
sdm845.dtsi, L4139 as of v5.11-rc7:
port@1 {
reg = <1>;
dsi0_out: endpoint {
};
};
This means you can essentially do:
&dsi0_out {
remote-endpoint = <&tianma_nt36672a_in_0>;
lanes = <0 1 2 3>;
};
in your dt :)
>>> + vddpos-supply = <&lab>;
>>> + vddneg-supply = <&ibb>;
>> With Angelo's latest series [1] merged in, I reckon you should explicitly configure lab/ibb (like in [2]),
>> as wrong settings (which CAN BE SET BY THE BOOTLOADER in some instances!!) can lead to hardware damage.
> So iirc in the case of beryllium device, these regulators are pre set
> by the bootloader and I can't find any reference of we
> setting/resetting it explicitly to switch ON the panel and display. So
> far default lab/ibb nodes are working fine for us and I'm hesitant to
> tinker around anything regulator related that can potentially damage
> the hardware. Having said that, I do see lab/ibb nodes being set in
> the downstream dts, with relevant soft-start and discharge-resistor
> properties and I can try switching to that once the new lab/ibb
> changes land upstream.
>
> Regards,
> Amit Pundir
>
I understand your concerns, however we actually did find out that at least one device had LAB/IBB set up by the bootloader in a way that could potentially damage the electronics, so I'm just making you aware. If it works as-is, it's probably OK.
Konrad
next prev parent reply other threads:[~2021-02-08 14:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 8:09 [PATCH v2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add DSI and panel bits Amit Pundir
2021-02-04 14:16 ` Konrad Dybcio
2021-02-05 13:15 ` Amit Pundir
2021-02-08 14:41 ` Konrad Dybcio [this message]
2021-02-10 8:21 ` Amit Pundir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bbeb403-2937-aebd-91ff-5682f9112dee@somainline.org \
--to=konrad.dybcio@somainline.org \
--cc=agross@kernel.org \
--cc=amit.pundir@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=john.stultz@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).